[Done 1.5.1 > 1.5.4] Add More Smilies 2.1

[don_miguel]

 

... I still have the same problem - and I do not know why? I've installed the final Version of the Smilies Mod - but the same problem. One extra smiley and one standard smiley - the extra smiley is shown, the standard one not ... the same source error as mentioned ...  

[source code]
width="" height="" alt="" border="0"
[/source code]

[Big P]

I looked, but I dont specify the height and width of the smiley images. Where are you finding this?

[don_miguel]

@Big P:

Here I got a test post for you to see what I mean ...

http://www.friends-lounge.de/index.php?board=3;action=display;threadid=1154

[Big P]

To be quite honest, I haven't a clue why that is  happening for you. YaBB doesn't even specify the size of the regular images, so I really haven't a clue!

Does this happen to anyone else?

[oldiesmann]

I haven't had any problems... Last time I tried posting a regular smiley next to an extra smiley, it worked fine...

[don_miguel]

OK. I try it once again locally ... only using Add More Smilies. Perhaps one of the other modifications adds this error ...  

[Big P]

well, as I've said before you're the only person this seems to affect. It is a good idea to try it on a localhost with no other mods installed though. Let me know how you get on.  

[don_miguel]

Locally - with Add more Smilies as single modification - it works ...

It think I have to do another 1.5.1 Final Update .... *puuuh*

[don_miguel]

Locally with all mods everything went fine. (with an empty database)

So I've updatet all files on my webserver - but: the same "error" like before and I do not know why. I've deleted the Smilies Table - created a new one - the same ... I'm going crazy ...

[splungent]

Hello all,
               I downloaded the 2.0 mod from the first post in this thread but board mod seems to throw 9 errors in various files.  Did I get the wrong file?  If there is a more updated one and if so could someone send me a link to it?  Thanks Big P for converting this one.

[Big P]

don_miguel, it sounds like another mod did something, but to be quite honest I haven't a clue. It's very odd indeed.

splungent, what version of YaBB SE are you using? And which link in the first post did you download? The Smilies 2.0 or the Smilies 1.6? Finally, if you are using YaBB SE 1.5.1 Final, is this your first YaBB SE install?

[splungent]

Hello Big P,
                  I decided to install the supermod with the smilies 2.0 in it.  I am happy to say it is working.  Thanks for the reply.

[Mart]

is the smilies mod compatible with YabbSE 1.5.2??

[Nathan_T]

Mart,

I'm using it on 1.5.2 with no problems.

Nathan

[chris]

There are some minor Bugs in the mod...

1. Disabling Smilies doesn't work

If you disable the smilies for a certain post, the "advanced" smilies are still shown... to fix this problem, open "Subs.php" and search for

Code Select Expand

  if ($enableSmilies)
     $message = parsesmilies($message);

replace it with:

Code Select Expand

  if ($enableSmilies)
  {
     $message = parsesmilies($message);

a few lines lower, you'll find:

Code Select Expand

  $message = parsecode($message);

you have to replace it with:

Code Select Expand

}
  $message = parsecode($message);

now, disabling smilies should work

2. more than 3 chars as file-extension

I haven't tested this, but if you put a file "test.jpeg" into the smilies-directory, this should cause some problems... the same happens if there are any directories in the smilies-directory...

you should think about using something like:

Code Select Expand

         while ($file = readdir($dh))
         {

            if (is_file($dir_to_open.'/'.$file))

to check if a file is really a file instead of comparing $file to "." and ".."

and I would use something like:

Code Select Expand

               $path_parts   = pathinfo($file);
               if ((strtolower($path_parts['extension'])=='gif') || (strtolower($path_parts['extension'])=='png') || (strtolower($path_parts['extension'])=='jpg') || (strtolower($path_parts['extension'])=='jpeg'))
               {
                  $desc      = basename($path_parts['basename'],'.'.$path_parts['extension']);
                  $code      = ':'.$desc.':';
                  $address   = $boardurl.'/smilies/'.$file;

to get proper filenames and check if a file is a smiley or something else....

jm2c