[Done 1.5.2] SearchNew Mod v.09

[Webby]

On B44 I have..............so it must be ok for B45..........

[Karsten]

On B44 I have..............so it must be ok for B45..........

great, where can i get it?

[Webby]

Code Select Expand

<file>
index.php
</file>

<search>
     'search2' => array("$sourcedir/Search.php", 'plushSearch2'),
</search>

<add>
     'searchnew' => array("$sourcedir/SearchNew.php", 'SearchNew'),
     'searchnew_markallread' => array("$sourcedir/SearchNew.php", 'SearchNew_MarkAllRead'),
     'searchnew_marktopicread' => array("$sourcedir/SearchNew.php", 'SearchNew_MarkTopicRead'),
     'searchnew_markboardread' => array("$sourcedir/SearchNew.php", 'SearchNew_MarkBoardRead'),
     'searchnew_markcategoryread' => array("$sourcedir/SearchNew.php", 'SearchNew_MarkCategoryRead'),
     'searchnew_cleanup' => array("$sourcedir/SearchNew.php", 'SearchNew_Cleanup'),
</add>


<file>
dutch.lng
</file>

<search>
  $img['search'] = '<img src="' . $imagesdir . '/search.gif" alt="' . $txt[182] . '" border="0" />';
</search>

<add>
  $img['searchnew'] = '<img src="' . $imagesdir . '/searchnew.gif" alt="' . $txt[searchnew1] . '" border="0" />';</add>

<search>
$txt['yse217'] = 'Live vanaf www.yabb.info...';
</search>

<add>
$txt['searchnew1'] = 'Zoek naar nieuwe berichten';
$txt['searchnew2'] = 'Markeer alle berichten als gelezen';
$txt['searchnew3'] = 'Markeer dit bericht als gelezen';
$txt['searchnew4'] = 'Limiet van';
$txt['searchnew5'] = 'bereikt.  Niet alle nieuwe berichten worden getoond.';
$txt['searchnew6'] = 'Negeer deze topic voor de komende 7 dagen';
</add>

<search>
  $img['search'] = $txt[182];
</search>

<add>
  $img['searchnew'] = $txt[searchnew1];
</add>

<file>
Sources/Subs.php
</file>

<search>
  if($username == "Guest") { $yymenu .= $menusep."<a href=\"$cgi;action=login\">$img[login]</a>$menusep<a href=\"$cgi;action=register\">$img[register]</a>";
  } else {
</search>


<add>
     $yymenu .= "$menusep<a href=\"$cgi;action=searchnew\">$img[searchnew]</a>";
</add>

Then, put the attached SearchNew.php in the Sources directory, and that should be all !

[Karsten]

great thx
it works  

[Forge]

I found a problem with the searchnew_cleanup function in my mod.  Basically this function is used to cleanup the log_topics table (which can get very full if you have a lot of users & topics).  It is only really important for people that are really concerned about performance.

Since the logtime on boards trumps the logtime on topics, we can set the logtime on the board and delete all the topic logtimes.  This results in 1 record for each user for each board instead of 1 record for each user for each topic.  The problem I ran into was that my code didn't account for some users that may never have marked a board read before.  Therefore after running the cleanup function, some users would see all the topics on some boards including all the old topics.

In any case, here's the code.  Please edit the Sources/SearchNew.php file and replace the SearchNew_Cleanup function with this one:

Code Select Expand

//-----------------------------------------
//  SearchNew_Cleanup
//
//  Purpose:  removes old history from
//   all users to help speed up the
//   search functions.
//-----------------------------------------
function SearchNew_Cleanup (){
   global $settings,$sourcedir,$db_prefix;
   
   $cleantime=time() - 259200;  //time now minus 30 days

   // We need to make sure that each user has a mark read record for each board since we're
   // counting on their board mark read entry to trump the topic mark read entries.
   $result2 = mysql_query("SELECT memberName from {$db_prefix}members");
   while (list($memberName) = mysql_fetch_row($result2)) {   
      // For each user, loop through the boards
      $result = mysql_query("SELECT c.ID_CAT,b.ID_BOARD ".
         "FROM {$db_prefix}categories as c,{$db_prefix}boards as b");
      while (list($ID_CAT,$ID_BOARD) = mysql_fetch_row($result)){
         $request = mysql_query("SELECT logTime ".
            "FROM {$db_prefix}log_mark_read ".
            "WHERE (memberName='$memberName' AND ID_BOARD=$ID_BOARD) LIMIT 1");
         if (mysql_num_rows($request)==0) {
            // entry for this user doesnt exist so create it.
            // Note this will create entries for users even in tables they
            // don't have permissions to.  This is not a security problem,
            // but you should know it exists in case you ever browse your
            // tables manually.
            $request = mysql_query("INSERT INTO {$db_prefix}log_mark_read ".
               "(logTime,memberName,ID_BOARD) ".
               "VALUES ($cleantime,'$memberName',$ID_BOARD)");
         }
      }
   }
   // Now update all entries in log_mark_read that are less than $cleantime
   $request = mysql_query("UPDATE {$db_prefix}log_mark_read SET logTime=$cleantime ".
      "WHERE (logTime < $cleantime)");   
   
   //Delete all log entries from log_topics prior to this logtime
   //this is done to conserve space in the database since the entry
   //in log_mark_read trumps the entry here.
   $request = mysql_query("DELETE FROM {$db_prefix}log_topics ".
      "WHERE (logTime < $cleantime)");
   // Redirect to BoardIndex when we're done.
   include_once "$sourcedir/BoardIndex.php"; BoardIndex();
   obExit();
   
}


Once this change is made, using the URL:
/index.php?action=searchnew_cleanup will mark all topics older than 30 days old as read for all users.

I'll include this change when I release the next version of the mod for 1.5.

[Anguz]

Webby, what would be the translation to english of that code you put in your last reply?  

[Webby]

Code Select Expand

$txt['searchnew1'] = "Search for New Messages";
$txt['searchnew2'] = "Mark ALL topics read (not including new posts since this search)";
$txt['searchnew3'] = "Mark this item as read";
$txt['searchnew4'] = "Limit of";
$txt['searchnew5'] = "reached.  Not all new messages have been displayed.";
$txt['searchnew6'] = "Ignore this topic for 7 days";


By-the-way, I get an error when I use the code (topic above) to "cleanup" the database :

Code Select Expand

2: Supplied argument is not a valid MySQL result resource
(/home/sites/salesplaza.nl/www/forum/Sources/SearchNew.php ln 498)


[Webby]

I hope this is ok :

Code Select Expand


//-----------------------------------------
//  SearchNew_Cleanup
//
//  Purpose:  removes old history from
//  all users to help speed up the
//  search functions.
//-----------------------------------------
function SearchNew_Cleanup (){
  global $settings,$sourcedir,$db_prefix;
 
  $cleantime=time() - 259200;  //time now minus 30 days

  // We need to make sure that each user has a mark read record for each board since we're
  // counting on their board mark read entry to trump the topic mark read entries.
  $result2 = mysql_query("SELECT ID_MEMBER from {$db_prefix}members");
  while (list($ID_MEMBER) = mysql_fetch_row($result2)) {  
     // For each user, loop through the boards
     $result = mysql_query("SELECT c.ID_CAT,b.ID_BOARD ".
        "FROM {$db_prefix}categories as c,{$db_prefix}boards as b");
     while (list($ID_CAT,$ID_BOARD) = mysql_fetch_row($result)){
        $request = mysql_query("SELECT logTime ".
           "FROM {$db_prefix}log_mark_read ".
           "WHERE (ID_MEMBER='$ID_MEMBER' AND ID_BOARD=$ID_BOARD) LIMIT 1");
        if (mysql_num_rows($request)==0) {
           // entry for this user doesnt exist so create it.
           // Note this will create entries for users even in tables they
           // don't have permissions to.  This is not a security problem,
           // but you should know it exists in case you ever browse your
           // tables manually.
           $request = mysql_query("INSERT INTO {$db_prefix}log_mark_read ".
              "(logTime,ID_MEMBER,ID_BOARD) ".
              "VALUES ($cleantime,'$ID_MEMBER',$ID_BOARD)");
        }
     }
  }
  // Now update all entries in log_mark_read that are less than $cleantime
  $request = mysql_query("UPDATE {$db_prefix}log_mark_read SET logTime=$cleantime ".
     "WHERE (logTime < $cleantime)");  
 
  //Delete all log entries from log_topics prior to this logtime
  //this is done to conserve space in the database since the entry
  //in log_mark_read trumps the entry here.
  $request = mysql_query("DELETE FROM {$db_prefix}log_topics ".
     "WHERE (logTime < $cleantime)");
  // Redirect to BoardIndex when we're done.
  include_once "$sourcedir/BoardIndex.php"; BoardIndex();
  obExit();
 
}

[Surfy]

work this mod for 1.5.1?

Surfy

[Webby]

Yes, it works in v1.5.1 Final (in use at yabb.nl )

[Surfy]

thanks!

Where can i dwonload the Package for YabbSe 1.5.1 ?

If possible the Boardmod one..

Surfy

[Forge]

FYI, I have updated my mod for version 1.5.2.

The YABBPak is available on my server (directions in the first post in this thread).

A zip version is available here:
http://www.flakshack.com/yabbse/attachments/searchnew_.09_for_yabbse_1.5.2.zip

See the README for installation instructions for the zip version.

No new features in this version, just the fixes to stay compatible with 1.5x's change in the log tables (replacing the membername field with the ID_MEMBER field).  Good change, BTW!

As usual, please let me know if you have any problems.

[Horseman]

a small bug?  

the yabb code cannot be seen in search new window.

Code Select Expand

[color=Red]Mann o Mann, da rollt ja echt...
or

Code Select Expand

Also ich würde sagen im [shadow=red,left,300]März[/shadow] siehts bei...

or

Code Select Expand

[quote author=Bill Ramsey link=board=3;threadid=11;start=0#msg56 date...

[taznumber1]

Do you not have that yabbpak anymore for 1.5.2 I do not see it listed anymore

[Mr T]

Will there be a update to version 1.5.3 available???