[beta 1.5.4] Relative URLs 1.3

[dschwab9]

well... that wouldn't work in win either

It does.  Click this link: http://www.yabbse.org/community/?board=158

As far as I know, that URL is perfectly legal, however, the mac version of IE doesn't like it.

[Anguz]

well... that wouldn't work in win either

It does.  Click this link: http://www.yabbse.org/community/?board=158

As far as I know, that URL is perfectly legal, however, the mac version of IE doesn't like it.

hahaha maaan... I'm learning so many new things working on these mods

yeah, it does, I guess it defaults to index.php and places the query after it

well, don't worry, I don't plan to compose that kind of relative urls

I'll post the new version of this mod in a few minutes, hold on

[Anguz]

updated to v1.4, I updated ob_anguz_url to v1.1 too, to have more control over future updates

also Spider URLs was updated to 1.1, I'm changing the first post in that thread right now

with the new change, making use of the base tag [Unknown] told me about (thank you!), now urls can be made relative even with Spider URLs installed too

with Relative URLs and Spider URLs together, the previous example, gave a byte count of 103,509, that's 16,321 bytes saved from the un-modded version

[[Unknown]]

Have you looked at Short URLs, by me?

-[Unknown]

I haven't read the code, although I've downloaded it some time ago... it shortens the url using less variables in the query, like:
http://www.yabbse.org/community/index.php?thread=25772/new
instead of:
http://www.yabbse.org/community/index.php?board=158;action=display;threadid=25772;start=new
right?

btw, I was about to ask if the base url worked with the search engine spider without problems, but I guess it does, cause I just checked php.net, they use it and their website is well indexed

Umm... no, that was not a mod.  I suggest you take another look... my Short URLs mod makes it so URLs are shorter - index.php?blah instead of http://wwww.dumb.com/long/path/same/as/this/does/actually/index.php?blah

-[Unknown]

[Anguz]

Umm... no, that was not a mod.  I suggest you take another look... my Short URLs mod makes it so URLs are shorter - index.php?blah instead of http://wwww.dumb.com/long/path/same/as/this/does/actually/index.php?blah

-[Unknown]

ah... I see...  

well, I didn't mean to make your mod less, I just needed a fix for relative urls when using look back in apache and that's how this mod came about (I didn't know the base tag yet)

hmm... I looked at the Short URLs now, it doesn't look like it changes the urls in images too, does it? I don't feel so bad now, otherwise they'd do almost the same

[Anguz]

dschwab9, could you try this changed code and tell me if it works for you now? it's just the Relative URLs mod, but if this method works fine for you now (it did for me), I'll modify Spider URLs too

Code Select Expand

function ob_anguz_url($buffer) {
   function relative_url($match1, $i){
      if(!stristr($match1['1'][$i], 'base')){
         global $boardurl, $scripturl;
         $pboardurl = parse_url($boardurl);
         $pscripturl = parse_url($scripturl);
         $pmatchurl = parse_url($match1['3'][$i]);
         $arr1 = array($scripturl . '?', $boardurl . '/', $pscripturl['path'] . '?', $pboardurl['path'] . '/');
         $arr2 = array('?', '', '?', '');
         if(($pmatchurl['scheme'] == 'http' &&  stristr($pboardurl['host'], str_replace('www.', '', $pmatchurl['host']))) || $pmatchurl['scheme'] == 'javascript' || $match1['3'][$i]{0} == '/')
            return $match1['1'][$i] . $match1['2'][$i] . '="' . str_replace($arr1, $arr2, $match1['3'][$i]) . '"';
         elseif($match1['3'][$i]{0} == '#')
            return $match1['1'][$i] . $match1['2'][$i] . '="' . str_replace($arr1, $arr2, $_SERVER['REQUEST_URI']) . $match1['3'][$i] . '"';
      }
      return $match1['0'][$i];
   }
   #relative_url
   preg_match_all('/([^<]*)(href|src|action)="([^"]*)"/i', $buffer, $match1);
   for($i = 0; $i < count($match1['0']); $i++){
      $match2[$i] = relative_url($match1, $i);
   }
   $buffer = str_replace($match1['0'], $match2, $buffer);
   return $buffer;
}

[Anguz]

I got rid of the nested function now, that's another possible conflict less for you... it's also faster

Code Select Expand

function ob_anguz_url($buffer) {
   global $boardurl, $scripturl;
   $pboardurl = parse_url($boardurl);
   $pscripturl = parse_url($scripturl);
   $arr1 = array($scripturl . '?', $boardurl . '/', $pscripturl['path'] . '?', $pboardurl['path'] . '/');
   $arr2 = array('?', '', '?', '');

   #relative_url
   preg_match_all('/([^<]*)(href|src|action)="([^"]*)"/i', $buffer, $match, PREG_SET_ORDER);
   for($i = 0; $i < count($match); $i++){
      $match1[$i] = $match[$i]['0'];
      if(!stristr($match[$i]['1'], 'base')){
         $pmatchurl[$i] = parse_url($match[$i]['3']);
         if(($pmatchurl[$i]['scheme'] == 'http' &&  stristr($pboardurl['host'], str_replace('www.', '', $pmatchurl[$i]['host']))) || $pmatchurl[$i]['scheme'] == 'javascript' || $match[$i]['3']{0} == '/')
            $match2[$i] = $match[$i]['1'] . $match[$i]['2'] . '="' . str_replace($arr1, $arr2, $match[$i]['3']) . '"';
         elseif($match[$i]['3']{0} == '#')
            $match2[$i] = $match[$i]['1'] . $match[$i]['2'] . '="' . str_replace($arr1, $arr2, $_SERVER['REQUEST_URI']) . $match[$i]['3'] . '"';
         else
            $match2[$i] = $match[$i]['0'];
      }else{
         $match2[$i] = $match[$i]['0'];
      }
   }
   $buffer = str_replace($match1, $match2, $buffer);

   return $buffer;
}

please try it out and let me know if it's working for you... this way I'll be able to release next version of each mod now working for all, hopefully  

[Anguz]

try both, please, I'm interested to know which one works or not

cause if nested functions isn't an issue (which I don't see why, since it's ok), then I'll keep using them

[dschwab9]

Sorry, I've been out of town all week.  I'll try it today though.

[Anguz]

Sorry, I've been out of town all week.  I'll try it today though.

cool! thx

[dschwab9]

That one didn't crash apache, but when I view the source, the URL's weren't relative either  

I tried both and didn't notice any difference in the results.

[Anguz]

That one didn't crash apache, but when I view the source, the URL's weren't relative either  

I tried both and didn't notice any difference in the results.

but it didn't crash! lol

it may have to do with your apache alias, although I thought it'd deal with it correctly... could you tell me your $boardurl and $scripturl?

[dschwab9]

$boardulr = "http://bbs.zuwharrie.com"

$scripturl = "$boardurl/content"

[Anguz]

hmm... it should work

"http://bbs.zuwharrie.com/content?board=1"

should turn into
"?board=1"

I did a couple of changes to the code since posting the last time, here's the one I'm using now (the other one should still work though)

Code Select Expand

ob_start('ob_anguz_url');
function ob_anguz_url($buffer) {
   global $scripturl;

   function spider_url($match){
      if(!strstr($match['2'], 'action') || strstr($match['2'], 'display') || strstr($match['2'], 'messageindex'))
         return $match['1'] . '/' . strtr($match['2'], "=;&", "-__") . $match['3'];
      return $match['0'];
   }

   function relative_url($match){
      if(!stristr($match['1'], 'base')){
         global $boardurl, $scripturl;
         $pboardurl = parse_url($boardurl);
         $pscripturl = parse_url($scripturl);
         $pmatchurl = parse_url($match['3']);
         $arr1 = array($scripturl . '?', $boardurl . '/', $pscripturl['path'] . '?', $pboardurl['path'] . '/');
         $arr2 = array('?', '', '?', '');
         if(($pmatchurl['scheme'] == 'http' &&  stristr($pboardurl['host'], str_replace('www.', '', $pmatchurl['host']))) || $pmatchurl['scheme'] == 'javascript' || $match['3']{0} == '/')
            return $match['1'] . $match['2'] . '="' . str_replace($arr1, $arr2, $match['3']) . '"';
         elseif($match['3']{0} == '#')
            return $match['1'] . $match['2'] . '="' . str_replace($arr1, $arr2, $_SERVER['REQUEST_URI']) . $match['3'] . '"';
      }
      return $match['0'];
   }

   #spider_url
   preg_match_all('/(' . preg_quote($scripturl, '/') . ')\?([^ "]+)([ "]+)/i', $buffer, $match_spider, PREG_SET_ORDER);
   rsort($match_spider, SORT_STRING);
   for($i = 0; $i < count($match_spider); $i++){
      $arr1_spider[$i] = $match_spider[$i]['0'];
      $arr2_spider[$i] = spider_url($match_spider[$i]);
   }
   $buffer = str_replace($arr1_spider, $arr2_spider, $buffer);

   #relative_url
   preg_match_all('/([^<]*)(href|src|action)="([^"]*)"/i', $buffer, $match_relative, PREG_SET_ORDER);
   rsort($match_relative, SORT_STRING);
   for($i = 0; $i < count($match_relative); $i++){
      $arr1_relative[$i] = $match_relative[$i]['0'];
      $arr2_relative[$i] = relative_url($match_relative[$i]);
   }
   $buffer = str_replace($arr1_relative, $arr2_relative, $buffer);

   return $buffer;
}

that has spider and relative urls in it, I hope it works

don't forget to have this code where it goes too

Code Select Expand

#get vars from friendly ulr
$arr1 = explode('/', $PATH_INFO);
$arr2 = explode('_', $arr1['1']);
foreach($arr2 as $element) {
   list($key, $value) = explode('-', $element);
   $$key = $value;
}

I really don't know what the problem is that it just doesn't wanna work right in your board  

let me know how it goes

[dschwab9]

don't forget to have this code where it goes too

Code Select Expand

#get vars from friendly ulr
$arr1 = explode('/', $PATH_INFO);
$arr2 = explode('_', $arr1['1']);
foreach($arr2 as $element) {
   list($key, $value) = explode('-', $element);
   $$key = $value;
}

Was I supposed to have that in there with that last code I tried?  I don't think I did.