Parse Error on upgrade.php

[japheth]

I'm upgrading a friends YaBB SE 1.4.1 board to 1.5.1 for him.

The first thing I did was take a dump of his database and download his php files and then I tested the upgrade locally and it worked fine and dandy.  That was on Apache 1.3, MySQL 3.23, PHP 4.3.1 and XP Pro.

I then uploaded all the appropriate upgrade files into their directories (Sources into Sources, all the other stuff to the root of the forum and the Packages files into the Packages directory).

However, when I browsed to upgrade.php, I received this error:

Code Select Expand


Warning: Unexpected character in input: '\' (ASCII=92) state=1 in /usr/local/etc/httpd/forums.db-forge.com/forgottenwars/upgrade.php on line 371

Parse error: parse error, expecting `']'' in /usr/local/etc/httpd/forums.db-forge.com/forgottenwars/upgrade.php on line 438


Just to double-check, I re-uploaded upgrade.php and made absolutely sure it was in ASCII mode.  But the same error occurred.

The server he is on is Linux using Apache 1.3.27, PHP 4.2.3 and MySQL 3.23.39.

Any help is appreciated.

[David]

PHP files should be in Binary.  The .js files in ASCII.

[japheth]

PHP files in binary is just for these files in particular I take it?

A quick look at SmartFTP's ASCII file extensions has PHP files defaulted to ASCII.  Which sort of makes sense since PHP files are simply text files.

[David]

Hmm, I guess you are right.  I just use auto select in SmartFTP.  Try binary and see if it works.

[japheth]

Actually, I think I may know what's going on.  I think that the single quotes might have to be escaped with another ' rather than a backslash.  I'll give it a shot and see what happens.

[japheth]

Well, I figured it out. It wasn't the quotes, it was the short open tag in this little snippet:

Code Select Expand


<?
global $errornum, $continue;
$continue = (isset($continue) ? $continue : $HTTP_GET_VARS['continue']);

@set_time_limit(300);


Just as a suggestion, I'd change all short open tags in your PHP files to <?php to make it a bit more portable.  I'm having to go through each PHP files one by one to make sure.

japh

[[Unknown]]

Well, I figured it out. It wasn't the quotes, it was the short open tag in this little snippet:

Code Select Expand


<?
global $errornum, $continue;
$continue = (isset($continue) ? $continue : $HTTP_GET_VARS['continue']);

@set_time_limit(300);


Just as a suggestion, I'd change all short open tags in your PHP files to <?php to make it a bit more portable.  I'm having to go through each PHP files one by one to make sure.

japh

Don't worry.  Only the upgrade uses short tags.

-[Unknown]