[Done 1.5.1] After Post

[Fizzy]

Not a problem Gobalopper

Glad to help

[Wiziwig]

Bugs. Say, where are you getting this variable from? ($settings['returnToPost'] == '0').. That should be
if ($modSettings['returnToPost'] == '0') instead. Your mod always gives the users the option menu because of this flaw.

Now, change that and they get taken back to the index, everytime, and no matter where their settings are for this mod. I believe that is because you are not setting your form choice variable in member db. It consistantly returns back to value 0.  

My Supermod users are screaming at me about this..

[[Unknown]]

Bugs. Say, where are you getting this variable from? ($settings['returnToPost'] == '0').. That should be
if ($modSettings['returnToPost'] == '0') instead. Your mod always gives the users the option menu because of this flaw.

Now, change that and they get taken back to the index, everytime, and no matter where their settings are for this mod. I believe that is because you are not setting your form choice variable in member db. It consistantly returns back to value 0.  

My Supermod users are screaming at me about this..

Perhaps you misunderstand, Wiziwig.

I just took a look at the entire mod, and it's right as rain.  Nowhere in the mod does it have $settings['returnToPost'], it only uses 'afterPost', and that is on the memebrs table not the settings table - that is, it's in $settings not $modSettings.

You can set this in your profile..... so it looks from the mod file.

-[Unknown]

[Gobalopper]

It uses $settings because it is loading that value from the members table not the mod settings.
There is no mod settings for this mod because the user controls where they want to be redirected not the admin.

[Wiziwig]

Yes and No and your partially right. the original code is if ($settings[24] == '0'), karmaSmiteLabel ?? ok, lets change that.. elseif ($settings['afterPost'] == '1') ok now this should work.. my bad, I posted something else from my tinkering.. now.. made post.. takes me to the option menu.. no this should not be..  look in my profile.. defaulted to back to post..  ok, so why" hmm.. change that.. dont change.. go back and its back where it was..  ok so the later half my reply was correct anyway.. I corrected to what you pointed out as you see.. still the same problem. its defaulting to back to post in profile and its taking you to the option menu when it shouldnt be..

Perhaps you misunderstand, Wiziwig.

I just took a look at the entire mod, and it's right as rain.  Nowhere in the mod does it have $settings['returnToPost'], it only uses 'afterPost', and that is on the memebrs table not the settings table - that is, it's in $settings not $modSettings.

You can set this in your profile..... so it looks from the mod file.
-[Unknown]

[Gobalopper]

Does the supermod change the $settings variable at all? My guess is your supermod is adding extra selects to the query for $settings and you aren't offsetting that value elsewhere.

[Wiziwig]

Let me see,. I have 25 select querys, 1 to 25 or as we look at it, 0 to 24...

function LoadUserSettings()

SELECT passwd, realName, emailAddress, websiteTitle, websiteUrl, signature, posts, memberGroup, ICQ, AIM, YIM, gender, personalText, avatar, dateRegistered, location, birthdate, timeFormat, timeOffset, hideEmail, ID_MEMBER, memberName, MSN, lngfile, afterPost

And your mod has 25 select querys.. So no, that's the problem.. I would like to note though, as a insurance that this would never be a problem, I should be able to use column name instead of column number. I think its presumptious of us to be building these variable assignments off of column numbers, as those can be changed.

So,. regardless if I use $settings[24] or if I use $settings[afterPost] I am getting the same results.

Any other thought provoking ideals you could throw my way??

Does the supermod change the $settings variable at all? My guess is your supermod is adding extra selects to the query for $settings and you aren't offsetting that value elsewhere.

[Gobalopper]

In your previous post you mentioned karmaSmiteLabel, where did that come from?

You should be able to select the column name depending on what mysql_fetch command is used.

[Wiziwig]

Q1. I dont think I was thinking clearly, the sun was still up Silly me I was counting columns from the table instead of from the query.

Q2. what mysql_fetch command ?? Hmm now we have flavors?  Elighten me with an example of your infinite wisdom, I dont think it'll help me with this problem but it's well worth adding these tidbits to the knowledge base. .

In your previous post you mentioned karmaSmiteLabel, where did that come from?

You should be able to select the column name depending on what mysql_fetch command is used.

[Gobalopper]

mysql_fetch_row and mysql_fetch_array return different arrays. So depending on which is used you may not be able to use ['somename'] when refering to an array.

[[Unknown]]

To explain further,

mysql_fetch_row returns a numerically indexed array, best for lists.... ie.

list ($col1, $col2, $col3) = mysql_fetch_row($result);

mysql_fetch_assoc returns an associative array, best for direct usage.... ie.

$row = mysql_fetch_assoc($result);
echo $row['memberName'];

mysql_fetch_array does both.... for example:

$result = mysql_query("
  SELECT 1 AS hi, 2 AS hello, 3 AS bye");
$row = mysql_fetch_array($result);
print_r($row);

Will produce:
Array (
  [ 0] => 1
  [hi] => 1
  [1] => 2
  [hello] => 2
  [2] => 3
  [bye] => 3
)

mysql_fetch_array is *somewhat* slower, due to having to do both.  It is best to use the one best for the situation instead.

-[Unknown]

[Wiziwig]

Oh but it's my understanding you can use [columnname] in an array if you use explode or if you compare, like this:
while ($row = mysql_fetch_array($request))
{ $aname = $row['columnname'];

True? Anyrate, back to my problem.. Any other suggestions? lol look like we both posted at the same time..

mysql_fetch_row and mysql_fetch_array return different arrays. So depending on which is used you may not be able to use ['somename'] when refering to an array.

[Gobalopper]

Updated for the final release of 1.5.1.

[Gobalopper]

The variable $settings uses mysql_fetch_row in Load.php. So in order to use ['sometext'] to access what is in it you will need to change $settings to use mysql_fetch_array in Load.php.

So you can either change the way $settings gets set or use numerical indexes. Thats my suggestion.

[multikon]

*reeeload*  

please make an update for 1.53/1.54  


thx & cya