Extra blank lines in preview

[Taildragger]

Noticed this in 1.5.1:

When I have a quote box and look at it in preview, the text before the quote box has one linebreak taken away, so that text with one blank line before the quote box will appear crammed right up against it.  After the text box, it's the opposite: there is an extra blank line.

Once I save the message and view it as a normal post, everything is back to normal (no removed or added blank lines).

Any ideas?

It's also kind of weird that in preview, the preview text seems to scale as a percentage of the browser window, but the input box (where you can make more changes, etc.) appears to be fixed width.

[[Unknown]]

Are you sure this is the most recent build?

-[Unknown]

[Spaceman-Spiff]

In preview mode, there's an extra line break before [ code ] tag

[Taildragger]

Are you sure this is the most recent build?

-[Unknown]

I downloaded it yesterday...  

[Taildragger]

In preview mode, there's an extra line break before [ code ] tag

So is this considered a bug then?  Is there an easy fix I can do myself?

Also, any idea why the preview box scales differently than the rest?  Is it intentional?  I can see it on this board, but it has to get really skinny before I do.  It shows up quick on my forum.

[Peter Duggan]

This preview discrepancy thing has been causing problems for a while:

Some line feed things here that have bothered me for a while. What you post isn't always what you get, but the same sequence in 1.5.1RC1 is screwy in a different way (like adding blank lines in different places and appearing different in preview than final post).

YES I WAS RIGHT!!!

*is happy*

Ah, but have you fixed that line-feed-discrepancy-between-preview-and-posted-message-when-using-quote-tags thing?

(Well, look at my post above...)

I keep fixing it, and some evil gremlin keeps UNfixing it... so I assume there's something wrong with it being fixed.

-[Unknown]

PS I acknowledge the great job the team do and hope my posts about this will be taken as feedback rather than criticism, but it would be nice to see the problem dead and buried for good!

[Taildragger]

I'm sorry to be a pain, but is this really tough to solve?  It bugs me on a daily basis because we do a lot of replies with numerous instances of quoting on my site.

I looked at the code some, but I have to admit that it's beyond me.  I just don't understand enough about how it works.  What changed from 1.5 to 1.5.1 to cause this?

I added this to the Sourceforge bug list but it got deleted?  

[[Unknown]]

I didn't close this bug.... I don't think.

I messed with it a lot, but I can't seem to fix the preview mode..  I can't even figure out what's so different between the two...

-[Unknown]

[Spaceman-Spiff]

i think u need to move these lines:

Code Select Expand

   $message2 = str_replace("\t","   ",$message2);
   $message2 = str_replace("\r","",$message2);
   $message2 = str_replace("\n","<br />",$message2);
before:

Code Select Expand

   if ($enable_ubbc)
   {
      $message2 = preparsecode($message2, $realname, $username);
      $es = ($ns == ' checked') ? 0 : 1;
      $message2 = DoUBBC($message2, $es);
   }

because that's how it's done in Post2() & Display.php, it's replaced first, before being parsed in doUBBC()

[[Unknown]]

That would explain it.

Here's hoping bookmarks work, because I can't do it just now...

-[Unknown]

[Taildragger]

Which file?

I searched in subs.php and could find no such lines.  Not one instance of "message2" at all.

Thanks.

i think u need to move these lines:

Code Select Expand

   $message2 = str_replace("\t","   ",$message2);
   $message2 = str_replace("\r","",$message2);
   $message2 = str_replace("\n","<br />",$message2);
before:

Code Select Expand

   if ($enable_ubbc)
   {
      $message2 = preparsecode($message2, $realname, $username);
      $es = ($ns == ' checked') ? 0 : 1;
      $message2 = DoUBBC($message2, $es);
   }

because that's how it's done in Post2() & Display.php, it's replaced first, before being parsed in doUBBC()

[Taildragger]

Nevermind, found it in post.php.

And, it works!  Thanks man.