[DONE 1.5.2] Enhanced Ban Mod 1.1

[snYpir]

ok, a working 1.5.1 version is in the first post. let me know if there are any problems.

i actually have my doubts about the default banning function (function banning()) in 1.5.1 - has anyone successfully tested banning without the enhanced ban mod?

it seems that the way that the ban log is written to is wrong. in 1.5.1, the log_banned table is written as follows:

Code Select Expand

      $registeredUserString2 = ($username != 'Guest' ? ',email' : '');
      $registeredUserString3 - ($username != 'Guest' ? ",'$settings[2]'" : '');
      $request = mysql_query("INSERT INTO {$db_prefix}log_banned (ip $registeredUserString2,logTime) VALUES ('$remote_ip' $registeredUserString3," . time() . ");") or database_error(__FILE__, __LINE__);
it should be:

Code Select Expand

      $registeredUserString2 = ($username != 'Guest' ? ',email' : '');
      $registeredUserString3 = ($username != 'Guest' ? ",'$settings[2]'" : '');
      $request = mysql_query("INSERT INTO {$db_prefix}log_banned (ip$registeredUserString2,logTime) VALUES ('$remote_ip'$registeredUserString3," . time() . ");") or database_error(__FILE__, __LINE__);
I have made the fix in the 1.5.1 version of the enhanced ban mod.

[Tenkoy]

Works in build 38.

[rickc]

snYper quick question where does this mod store the ban.. After I installed it I banned a fake name I made forgetting it bans the IP. I had to uninstall the mod.


Good thing I only banned the fake name for 30 days, but my IP is still kicked...

I looked in the data base, but only saw the IP ban log, I cleared it, deleted the fake user I banned & uninstalled the mod. (though the database) When I reinstalled the mod my IP was still blocked. hehe

can I fix or should I wait 30 days

Thanks in advance 4 the help
Btw way I liked the mod a lot, & next time I test it, it will be at work
rickC

[David]

It is in the enhanced ban table in your database.

[rickc]

thanks;)

[Wiziwig]

Suggestions for changes:

1. Do NOT Ban by IP when banning from profile. Banning by IP should be a selectable option in Modsettings. Most people will find that when banning by IP, you run the risk of banning more than your intended target, as IP's are dynamicly assigned in many cases.

2. All the ban options controlled in profile and in Admin ban function should be selectable in modsettings.

3. Ban by e-mail and user name in the profile as you would if you were to ban that person through admin ban feature.

4. After you have banned a person, that person can at first login and see the index. When that person attempts to click on something they either will get a error msg from $txt[1] which they should not be getting,. or they will get NOTHING, it simply knocks them back to the login, or they at rare times will get $txt[430] which they should be getting.

5. The user never gets a notification as to why they got banned. Instead of kicking $txt[430] kick your own $txt with the description on why they are banned and include a IM link to the webmaster.

6. For you to do that, you would have to write the application to detect the IP of the visitor.

7. Import the banlist from the original setup, now that you replaced the admin banlist the original data is not accessable.

Enhanced Ban Mod 1.1

For YaBB SE 1.5.1

[snYpir]

Thanks for so many suggestions

1. Do NOT Ban by IP when banning from profile. Banning by IP should be a selectable option in Modsettings. Most people will find that when banning by IP, you run the risk of banning more than your intended target, as IP's are dynamicly assigned in many cases.

Yes, it should be.

2. All the ban options controlled in profile and in Admin ban function should be selectable in modsettings.

Uh-huh.

3. Ban by e-mail and user name in the profile as you would if you were to ban that person through admin ban feature.

I disagree, I wrote the profile feature so that it was a single-click affair. I may add a link to the ban page from the profile page, however.

4. After you have banned a person, that person can at first login and see the index. When that person attempts to click on something they either will get a error msg from $txt[1] which they should not be getting,. or they will get NOTHING, it simply knocks them back to the login, or they at rare times will get $txt[430] which they should be getting.

At the moment the banning is done after user settings are loaded, in the same way as the default ban system does. This is the way it has to be - only IP banning can be done before the settings load. I have not experimented with the results of the banning - this is indeed something that should be done, because the resultant error msg should be the same, every time.

5. The user never gets a notification as to why they got banned. Instead of kicking $txt[430] kick your own $txt with the description on why they are banned and include a IM link to the webmaster.

That would be nice, yeah.

6. For you to do that, you would have to write the application to detect the IP of the visitor.

No, this could be done anywhere. The enhanced_ban() function would be the place to do it, and obviously it would simply be included in the output with the 'you have been banned' msg.

7. Import the banlist from the original setup, now that you replaced the admin banlist the original data is not accessable.

The installer (ie the db mod) will copy everything from the old ban table into the new ban table. Hence there is no requirement to access the old table.

Ok, a ton of good suggestions. Feel free to implement them if you get the time - i don't think i will be doing any more YaBB mods for at least a couple of weeks. When i get back into it, i will look at making the suggested changes - and yeah, all of them are required changes, because banning people is a very serious business

[Wiziwig]

Yep it had a problem,  your fix took care of it. I removed your mod for now until you can address those changes. Had you reported this bug through bugtraq?

i actually have my doubts about the default banning function (function banning()) in 1.5.1 - has anyone successfully tested banning without the enhanced ban mod?

[snYpir]

Yep it had a problem,  your fix took care of it. I removed your mod for now until you can address those changes.

You will be waiting awhile, my priority is not YaBB these days. If anyone else wants to make changes, feel free.

Had you reported this bug through bugtraq?

No.

[GWP]

This is a really useful mod for my board.
I get 2 errors, both times the editing part of the mod has nothing to do? (Steps 3 & 7)
has anyone got this to work?

[snYpir]

This is a really useful mod for my board.
I get 2 errors, both times the editing part of the mod has nothing to do? (Steps 3 & 7)
has anyone got this to work?

Yes, of course other people have got it working.

What version of yabb are you running? What other mods do you have? Errors during a boardmod install are very easy to fix - please provide some more information.

[GWP]

step 3 searches admin.php for:

<a href="' . $cgi . ';action=ipban">' . $txt[206] . '</a><br />

to replace it with:

<a href="' . $cgi . ';action=enhancedban">' . $txt[206] . '</a><br />

thats not hard to chnage, but i cannot find any ref to it in the admin.php at all. even searching for "[206]" brings no results.

step 7 searches profile.php for:

<td colspan="2">' . $sig .'</td>

Boardmod cannot find it, I can using my text editor, (maybe some extra spaces)

So really, its step 3 which is the problem, as I have no idea where to insert this text and wonder why my admin.php doesn't have it there in the first place?

My installed mods are in my sig.
Thanks

[GWP]

managed to get it installed.
just a few changes, probably due to other mods.

Jusrt one question, becuase of previous posters remarks about banning yourself, I want to test it.
Can I ban a member for "0.5" days??

I tried it but nothing happened.

[snYpir]

updated for 1.5.2 - see first post.

GWP - what is your situation? i've been out of the loop for a long while

[Daniel D.]

If I ban a member, logout and try to login as another member, I'm banned forever...