[Tested BETA] Bookmarks 1.4.1 and 1.5.0

[Joseph Fung]

Here you go - this is almost ready to release, I'd just like one last round of tests if anyone has the time...


Edit:
I am adding the updated mod, now zip contains a updated mod file for 1.5.1 Final 4/19/2003

Nemey

Horseman german mod version:
http://www.h-h-c.de/downloads/bookmarks.rar

[snYpir]

I love the mod - it is original and works well.

My only concern it the fact that it modifies some of the critical DB queries - which of course means that other mods that reference these queries (ie with board mod <search for> statements) won't install.

How do people feel about having a seperate DB query for mods such as this?

There is slightly more overhead, but it will conflict less with other mods.

Joseph - For my forum, I re-wrote the parts of your mod because I would rather have that seperate DB query than modify the original LoadUser() DB query.

I have emailed my version to you, Joseph (can't attach except on the original post).

As I said, this is a great mod, but as a rule I don't implement mods that change core yabb queries. I would personally prefer it if you changed the Load.php accordingly, but of course I am just one dude out of the thousands that frequent this board (so i'll understand if you don't change anything).

cheers

[PioneeR]

I have run the dbupdate (which completed ok).

Appled the mod.. no probs there either.

put <yabb bookmarks> in my template

and made sure that bookmarks were enabled.

But I cant see them!?

What have i done wrong??

[Ben_S]

did you find out, I cant see em either

[Mr.Sins]

enable it in your mod settings section

[Ben_S]

it is enabled
it is enabled in profile
have added <yabb bookmarks> to template

[PioneeR]

I still have the same problem...  

it is enabled
it is enabled in profile
have added <yabb bookmarks> to template

[PioneeR]

I can alter the Enable Bookmarks in my profile fine.

But everytime I try to enable it in Mod Settings.. it goes back to unticked?  

I didnt get any errors with the dbchanges...

[[Unknown]]

Is the mods setting even in your database?  I would double check...

-[Unknown]

[PioneeR]

It is working for me kind of.

I cant seem to turn it on/off in mod settings!?!?

[PioneeR]

In table yabbse_settings i have showBookmarks (which is set to 1)

I will double check to see if I have made a mistake when applying the change to modsettings.php  

[PioneeR]

I have checked and the following are there...

any ideas why I cant seem to control it from mod settings?

<Edit file>
Sources\ModSettings.php
</Edit file>

<Search for>
      $enableTrackStatsChecked = ($modSettings['trackStats'] == '1')?' checked':'';
       $enableHitStatsChecked = ($modSettings['hitStats'] == '1')?' checked':'';
</Search for>

<Add after>

   $showBookmarksChecked = ($modSettings['showBookmarks'] == '1')?' checked':'';

</Add after>

<Search for>
   $onoffArray['cal_AllowSpan'] = 'cal_allowspan';
</Search for>

<Add after>
   $onoffArray ['showBookmarksChecked'] = 'showBookmarks';
</Add after>

<Search for>
  </tr><tr>
    <td class="windowbg2" bgcolor="$color[windowbg2]" colspan="2" align="center" valign="middle">
    <HR size="1" width="100%" class="windowbg3"><input type="submit" value="$txt[10]">
    </td>
  </tr>
</Search for>

<Add before>
                     </tr><tr>
                        <td class="windowbg2" bgcolor="$color[windowbg2]" colspan="2"><hr size="1" width="100%" class="windowbg3" /></td>
                     </tr><tr>
                        <td class="windowbg2" bgcolor="$color[windowbg2]"><font size="2">$txt[bookmarks18]</font></td>
                        <td class="windowbg2" bgcolor="$color[windowbg2]"><input type="checkbox" name="showBookmarksChecked" value="1"$showBookmarksChecked /></td>
</Add before>

[Koth]

So is the version thats up the one with the seperate query as I would rather have that version if at all possible.  This does look a quality and original mod and the extra "overhead" would be worth it since I run a heavilly modded YaBBse board.

[Ben_S]

Mine has all the required DB entries, but doesnt show

[Lazy]

hi =)

mine the same, all entries are made but it`s not shown hm.