[Discontinued 1.5.0] Package Manager bugfix

[[Unknown]]

This fixes the issue described in
http://www.yabbse.org/community/index.php?board=178;action=display;threadid=16285

When selecting the "Del Mod List" or "Add Server" option in the package manager, it goes to "$scripturl?action=pkflushlist" or action=, which is obviously a PHP error... ie. you need to make it <?php echo $scripturl;?>

Fixed. (actually I was wrong it had to be ' . $scripturl . ')

Pack Server: http://gbaetc.homeip.net/yypack
Boardmod: http://gbaetc.homeip.net/yypack/fixpacman1.5.mod
YaBBpack: http://gbaetc.homeip.net/yypack/fixpacman1.5.mod.yp
Zip file: http://gbaetc.homeip.net/yypack/fixpacman1.5.zip

If you want to use the pac man to install it, as apposed yo boardmod or uploading it and using pacman... replace your server.list with:

Code:yabbse.org Avatars|^|http://www.yabbse.org/packages/as
yabbse.org Mods|^|http://www.yabbse.org/packages/mod
yabbse.org Language Packs|^|http://www.yabbse.org/packages/lp
Matt|^|http://www.mattsiegman.com/YaBBSE/Packages
Chris|^|http://www.agigames.com/boardmod/Packages
GBAetc|^|http://gbaetc.homeip.net/yypack

(or at least add the last line....)

Thanks, hope it was helpful.

-[Unknown]

[David]

Just looking at your mod file it doesn't seem it does anything.  

[[Unknown]]

You posted in both places?

Anyhow, it does - when you echo 'var = $var'; it doesn't print $var, so you have to make it echo 'var = ' . $var; instead.  This is the same difference - only with $scripturl.

Thanks for taking a look, however.

-[Unknown]

[David]

I ask because neither your yabb pack nor mod file have any search or replace tags.

[[Unknown]]

Not at all, take a look again:

Code Select Expand

<id>
Fix Pacman 1.5
</id>

<version>
1.01
</version>

<mod info>
Fixes the bugs that make the package manager put you at $scripturl?action=whatever
</mod info>

<author>
[Unknown]
</author>

<homepage>
http://gbaetc.homeip.net/
</homepage>

<edit file>
Sources/Packages.php
</edit file>

<search for>
                        <a href="$scripturl?action=pkflushlist">[ ' . $txt['yse198d'] . ' ]</a>
</search for>

<replace>
                        <a href="' . $scripturl . '?action=pkflushlist">[ ' . $txt['yse198d'] . ' ]</a>
</replace>

<edit file>
Sources/PackageGet.php
</edit file>

<search for>
                        <form action="$scripturl?action=pgadd" method="post">
</search for>

<replace>
                        <form action="' . $scripturl . '?action=pgadd" method="post">
</replace>

[David]

Werid, it was IE.  Normally it shows me the contents of the .mod file but it wasn't this time.

[[Unknown]]

That's my fault.  I'm running .NET Server build 3663, and it has an incomplete security setup on IIS 6.0 (being a beta build).... regardless, it won't show .mod, .list or .mod.yp files, so I had to route them through a scripting module. (namely ASP - hey it's called jurryrigging for a reason and I wanted <?php ?> tags to stay intact)

But, all this really doesn't matter to YaBBSE or boardmod. (if you save the webpage to a file)

-[Unknown]

[irbrian]

When trying to apply the "Official Bug Fixes 01/02/2003" Mod through the packman, I get the following error:

An Error Has Occurred!

2: Unable to create 'Sources/Display.php~': Permission denied
(/home/user/public_html/yabbse/Sources/Packages.php ln 358)

This occurs during an attempt to replace the line:

Code Select Expand

$reportToModerator = '<font size="1"><a href="' . $cgi . ';action=reporttm;thread=' . $viewnum . ';id=' . $counter . ';subject=' . $msub . ';poster=' . $mname . ';msgid=' . $mid . '">' . $txt['rtm1'] . '</a></font>  ';
My Sources folder is chmod'd 777.

[irbrian]

I actually just noticed that every single search/replace attempt during this mod application reported "string not found." This is very strange since the Test completed successfully!

[[Unknown]]

Interesting.....

It thinks it can't create files, and it can't find the right lines.... odd.

You might try downloading and euploading a clean copy of 1.5.0....

-[Unknown]

[irbrian]

I actually just noticed that every single search/replace attempt during this mod application reported "string not found." This is very strange since the Test completed successfully!

My apologies, this part is actually not true. I didn't realize I accidentally refreshed the install mod page   so naturally the strings that had already been replaced, could no longer be found.

Furthermore, I've determined the cause of the problem. Its always the simple things -- Display.php~ already exists. I feel it would be handy for the Packman to determine whether backups already exist before attempting to create a backup file. It could cause a serious problem with some mods.

[[Unknown]]

Don't you have overwrite access, though?  It works for me as is... although I can make it unlink the file.

-[Unknown]

[irbrian]

I do indeed. Stranger still, though -- the problem has only occurred with this ONE package. Every other mod since works fine.

It makes me think that maybe the bugfix package, once it was finally installed, actually fixed the backup overwriting problem as well.