[Done 1.5.1 > 1.5.4] Add More Smilies 2.1

[chris]

uhmm... and btw.... you're accessing the smilies-directory on numerous places... i think it would be much easier to use one funtion to read the directory instead of coding the same stuff over and over again

I wrote a little something...

Code Select Expand

function readSmileyDir()
{
   global $boarddir,$boardurl;

   $dir_to_open   = $boarddir.'/smilies';
   $dh      = opendir($dir_to_open);
   $smileydata   = array();

   while ($file = readdir($dh))
   {

      if (is_file($dir_to_open.'/'.$file))
      {

         $path_parts   = pathinfo($file);
         if ((strtolower($path_parts['extension'])=='gif') || (strtolower($path_parts['extension'])=='png') || (strtolower($path_parts['extension'])=='jpg') || (strtolower($path_parts['extension'])=='jpeg'))
         {
            $smileydata[]   = array ( 'desc'   => basename($path_parts['basename'],'.'.$path_parts['extension']),
                       'code'   => ':'.basename($path_parts['basename'],'.'.$path_parts['extension']).':',
                       'url'      => $boardurl.'/smilies/'.$file);
         }

      }

   }

   return $smileydata;
}

so you could simply do something like this in subs.php:

Code Select Expand

      else if ($modSettings['smileydirEnable'] == '1')
      {

         $smilies   = readSmileyDir();
         
         foreach ($smilies as $cursmiley)
         {
            $message   = str_replace($cursmiley['code'],'<img src="'.$cursmiley['url'].'" alt="'.$cursmiley['desc'].'" />',$message);
         }

      }

I think this would reduce the size of the code and makes it easier to change things.....

(the above code is mostly UNTESTED!)

[Big P]

OMG! Why can't this mod die!!? I'm trying to devot all my time to PHPNews!

All of above are great suggestions Christian, but I wrote the V2 code like a year ago! I dont want to bother updating it! But.... I suppose I might as well!

[chris]

OMG! Why can't this mod die!!? I'm trying to devot all my time to PHPNews!

All of above are great suggestions Christian, but I wrote the V2 code like a year ago! I dont want to bother updating it! But.... I suppose I might as well!

I'm currently writing my own Smilies-MOD....

[PeterPaul]

Oh i've added some tables, modified some files and upload these.

And now, i can say, THIS IS THE BEST MOD



THANK YOU BIG P and ALL THE YABBSE TEAM,

YOU ARE THE BEST

[Big P]

OMG! Why can't this mod die!!? I'm trying to devot all my time to PHPNews!

All of above are great suggestions Christian, but I wrote the V2 code like a year ago! I dont want to bother updating it! But.... I suppose I might as well!

I'm currently writing my own Smilies-MOD....

Why bother? There are like 3 (unless you mean for ......?)

[chris]

Why bother? There are like 3 (unless you mean for ......?)

No, not for ....... But it could VERY easily be added to ......

I'm writing it mostly because I don't like the existing versions.... and mine allows Smiley-Upload

[Big P]

Meh!

Let the battles begin!

Anyhow, I've been rewriting the Smilies Mod, not adding any new features but I have been improving its speed.

I have a beta of the next version, if someone could test it out. It *should* work, as I've tested it and it worked fine for me.

[Douglas]

Send it here, I have one site that wants it.

[Ben_S]

Send it here, I have one site that wants it.

He attached it

[oldiesmann]

Meh!

Let the battles begin!

Anyhow, I've been rewriting the Smilies Mod, not adding any new features but I have been improving its speed.

I have a beta of the next version, if someone could test it out. It *should* work, as I've tested it and it worked fine for me.

Is the version that you attached the beta version or is there another version on its way? I've set up a "test" board on Lycos UK (the one I've been using to test mods), and I will gladly test it for you...

[Ricbr]

I have installed the mod and can see all the smilies to add to a message...however when i click on them to add them to a message...they never add.  I can type in the text needed to add the smiley...but is there a trick to allow me to add them by clicking on them?

Appreciate the help in advance.

Ric

[oldiesmann]

Make sure you editied your code properly... I think the part that allows you to click on smilies to add them is in post.php...

[Big P]

Yeah, the latest code was attached above.  Plus that error was most likely the mods fault, as it is in Beta. I'll test it out tomorrow on a clean install and let you know if I find the error.  

[Juvenall Wilson]

Here's a quick addon if you will. I was getting complaints from users that if the vB style window was open, they couldn't navagate any place else.

Now, I don't know if this was said/posted here before, this thread is far too big to sort through..lol

Anyhow,

Code Select Expand


<edit file>
Sources/Smilies.php
</edit file>

<search for>
<BODY bgcolor="' . $color['windowbg2'] . '" onblur="this.focus();">
</search for>

<replace>
<BODY bgcolor="' . $color['windowbg2'] . '">
</replace>


Now users don't have to close it to go to another program or navagate in IE..

[Big P]

Err, that's an add-on that people wanted. If you want to move around close the window! Anyway, as I said, it was requested.
Now, I'm still owrking on Smilies 2.1, which is coming along very nicely