[Tested BETA] Bookmarks 1.4.1 and 1.5.0

[[Unknown]]

After you add it, is it dedicated to the database?

Try adding one with the Add (the one that adds the current page.) button... that work?

-[Unknown]

[Wiziwig]

yeah, I added. that's how the bookmark got in the edit list.  I even added another one. still the same results.

I go to add/edit/remove or whatever in the editor window and everything appears in the bookmark view list. I go click on the go or click on the home or some other button in the index and the bookmark view list drops everything.

[Nemesis]

What browser are you using?

It works on my site and horseman...

[Wiziwig]

Win98SE, IE 6.0.2600

What browser are you using?

It works on my site and horseman...

[Nemesis]

did you copy the codes from the above file, or dl it from post 1?

[Wiziwig]

DL from post 1, but I did skim over the posted code and it appears that function yyBookmarks() in subs is the same for both.

did you copy the codes from the above file, or dl it from post 1?

[Nemesis]

try this: (replaces the yyfunction before and after including bookmark function. This is straight from the subs.php i am using live.

Code Select Expand


function getMemberID($messageID)
{
   global $db_prefix;
   $result = mysql_query("
      SELECT IFNULL(mem.ID_MEMBER,-1) AS ID_MEMBER
      FROM {$db_prefix}messages AS m
         LEFT JOIN {$db_prefix}members AS mem ON (mem.ID_MEMBER=m.ID_MEMBER)
      WHERE m.ID_MSG=$messageID") or database_error(__FILE__, __LINE__);
   if (mysql_num_rows($result) > 0)
   {
      $row = mysql_fetch_array($result);
      return $row['ID_MEMBER'];
   }
   else
      return -1;
}

function yyBookmarks(){
   global $settings, $db_prefix, $ID_MEMBER, $username, $txt, $yytitle, $scripturl, $HTTP_SERVER_VARS, $modSettings;

   $onchange = ' onchange="window.location.href=this.options[this.selectedIndex].value;"';

   if ($username != 'Guest' && $modSettings['showBookmarks'] == '1')
   {
      $sql = "SELECT url, title FROM {$db_prefix}bookmarks WHERE ID_MEMBER = '" . $ID_MEMBER . "' ORDER BY display_order";
      $request = mysql_query ($sql);
      ?>
      <script>
      function addOption(theSel, theText, theValue)
      {
         var newOpt = new Option(theText, theValue);
         var selLength = theSel.length;
         theSel.options[selLength] = newOpt;
      }
      </script>
      <?php
      echo '<table border=0 cellspacing=0 cellpadding=0><form name="bookmarkFrm"><tbody><tr><td><b>' . $txt['bookmarks1'] . '</b> <select name="bookmarks"'.$onchange.'>';

      while ($row = mysql_fetch_assoc($request))
         echo '<option value="' . $row['url'] . '">' . $row['title'] . '</option>';      

      $addUrl = $scripturl . '?action=bookmarks;sub=add;title=' . urlencode($yytitle) . ';url=' . urlencode(urlencode($scripturl.'?'.$HTTP_SERVER_VARS['QUERY_STRING']));

      echo '</select> <input type=button value="' . $txt['bookmarks8'] . '" onclick="window.location.href=bookmarks.options[bookmarks.selectedIndex].value;"> <input type=button value="' . $txt['bookmarks2'] . '" onclick="window.location.href=\'' . $addUrl . '\';"> <input type=button value="' . $txt['bookmarks3'] . '" onclick="window.open(\'' . $scripturl . '?action=bookmarks;sub=edit\',\'bookmarks\',\'toolbar=no,location=no,status=no,menubar=no,scrollbars=no,width=500,height=220,resizable=no\');"></td></tr></tbody></form></table>';
  }
}

function un_html_entities ($string)
{
   $trans_tbl = get_html_translation_table (HTML_ENTITIES);
   $trans_tbl = array_flip ($trans_tbl);
   $trans_tbl['&#039;'] = "'";
   return strtr ($string, $trans_tbl);
}


[Wiziwig]

I must of been wrong about what the mod has for function yyBookmarks() and what you posted, I copied/pasted over function yyBookmarks() your posting for it and it now works. Somebody outa change that archive file maybe?

[Nemesis]

I will, weird....

[Nemesis]

Okay I updated the mod file and re-uploaded to yabbse.

If anyone has any problems still, just do the same as I had Wizwig do a couple post up...

[Wiziwig]

it's a smart mod nem. may I ask can I have permission to add this to Supermod ??

[Nemesis]

I wish I could give you permission but it is really Joseph mod, I just updated it to work with 1.5.1

I am sure if you IM him he won't mind.

[Wiziwig]

Another bug to report. If admin has enabled bookmarks, and user disables bookmarks in profile, bookmarks show regardless.

[Horseman]

this is in subs.php, function bookmarks()

Code Select Expand


<search for>
function yyBookmarks(){
  global $settings, $db_prefix, $ID_MEMBER, $username, $txt, $yytitle, $boardurl, $HTTP_SERVER_VARS, $modSettings;

  $onchange = ' onchange="window.location.href=this.options[this.selectedIndex].value;"';

  if ($username != 'Guest' && $modSettings['showBookmarks'] == '1')
  {
     $sql = "SELECT url, title FROM {$db_prefix}bookmarks WHERE ID_MEMBER = '" . $ID_MEMBER . "' ORDER BY display_order";
     $request = mysql_query ($sql);
     ?>
     <script>
     function addOption(theSel, theText, theValue)
     {
        var newOpt = new Option(theText, theValue);
        var selLength = theSel.length;
        theSel.options[selLength] = newOpt;
     }
     </script>
     <?php
      echo '<table border=0 cellspacing=0 cellpadding=0><form name="bookmarkFrm"><tbody><tr><td><b>' . $txt['bookmarks1'] . '</b> <select name="bookmarks"'.$onchange.'>';

      while ($row = mysql_fetch_assoc($request))
         echo '<option value="' . $row['url'] . '">' . $row['title'] . '</option>';     

      $addUrl = $boardurl . '?action=bookmarks;sub=add;title=' . urlencode($yytitle) . ';url=' . urlencode(urlencode($boardurl.'?'.$HTTP_SERVER_VARS['QUERY_STRING']));

      echo '</select> <input type=button value="' . $txt['bookmarks8'] . '" onclick="window.location.href=bookmarks.options[bookmarks.selectedIndex].value;"> <input type=button value="' . $txt['bookmarks2'] . '" onclick="window.location.href=\'' . $addUrl . '\';"> <input type=button value="' . $txt['bookmarks3'] . '" onclick="window.open(\'' . $boardurl . '?action=bookmarks;sub=edit\',\'bookmarks\',\'toolbar=no,location=no,status=no,menubar=no,scrollbars=no,width=500,height=220,resizable=no\');"></td></tr></tbody></form></table>';
  }
}
</search for>

<replace>
function yyBookmarks(){
  global $settings, $db_prefix, $ID_MEMBER, $username, $txt, $yytitle, $scripturl, $HTTP_SERVER_VARS, $modSettings;

  $onchange = ' onchange="window.location.href=this.options[this.selectedIndex].value;"';

   if ($username != 'Guest' && $modSettings['showBookmarks'] == '1')
   {
   $request = mysql_query("
      SELECT ID_MEMBER, showBookmarks
      FROM {$db_prefix}members
      WHERE ID_MEMBER='$ID_MEMBER'") or database_error(__FILE__, __LINE__);
      $memsettings = mysql_fetch_array($request);

      if ($memsettings['showBookmarks'] == '1')
      {
         $sql = "SELECT url, title FROM {$db_prefix}bookmarks WHERE ID_MEMBER = '" . $ID_MEMBER . "' ORDER BY display_order";
         $request = mysql_query ($sql);
         ?>
              <script>
              function addOption(theSel, theText, theValue)
        {
           var newOpt = new Option(theText, theValue);
           var selLength = theSel.length;
           theSel.options[selLength] = newOpt;
        }  
        </script>
        <?php
         echo '<table border=0 cellspacing=0 cellpadding=0><form name="bookmarkFrm"><tbody><tr><td><b>' . $txt['bookmarks1'] . '</b> <select name="bookmarks"'.$onchange.'>';
         while ($row = mysql_fetch_assoc($request))
         echo '<option value="' . $row['url'] . '">' . $row['title'] . '</option>';   
         $addUrl = $boardurl . '?action=bookmarks;sub=add;title=' . urlencode($yytitle) . ';url=' . urlencode(urlencode($boardurl.'?'.$HTTP_SERVER_VARS['QUERY_STRING']));
         echo '</select> <input type=button value="' . $txt['bookmarks8'] . '" onclick="window.location.href=bookmarks.options[bookmarks.selectedIndex].value;"> <input type=button value="' . $txt['bookmarks2'] . '" onclick="window.location.href=\'' . $addUrl . '\';"> <input type=button value="' . $txt['bookmarks3'] . '" onclick="window.open(\'' . $boardurl . '?action=bookmarks;sub=edit\',\'bookmarks\',\'toolbar=no,location=no,status=no,menubar=no,scrollbars=no,width=500,height=220,resizable=no\');"></td></tr></tbody></form></table>';
      }
   }   
}
</replace>


[Nemesis]

Or just download the file again, i have updated it.



Thanks Horseman!