[beta 1.5.4] Friendly URLs v1.3

[Anguz]

I tried that code I wrote for pfabb in my yse board and it works great, cause it also changes the urls in img tags into relative urls

I opened a thread with and without the new version, and making the urls relative had saved almost 9K of bandwith, it doesn't sound much, but they add up page after page

I also fixed the "previous/next" links, cause the variable name is prev_next and it got changed when doing the rewrite, so they're working fine now

I updated the first post with v1.3

note: the problem mentioned in the previous post, applies to pfabb only, yse works great

[dschwab9]

What do I need to remove the make it not do relative URLs?  I know  it has something to do with $_SERVER['SCRIPT_NAME']) , but I just confused myself when I tried to figure it out  

Reason I can't have relative URLs is I have multiple domains pointing to my forum.  Ie, the main site is http://www.domain1.com, and domain2.com and domain3.com are aliased to it.

Right now, since all the links are absolute, the first link they click, they get redirected to domain1.com.  But if I go to relative, I'm going to have a big mess with cookies being in the wrong domain, users can't login, etc.

Maybe you should consider putting relative links as a option in the admin center?

[Anguz]

I understand

I'm making Friendly URLs and Relative URLs two separate mods now, I'll post them a bit later tonight

for now, use the version of Friendly URLs that worked for you fine, just add a couple of conditions to those you wrote so that strings that have '-' or '_' are skipped too

sorry for the trouble

I'll make relative urls distiguish when the subdomains are different, so you'll be able to use that mod as well if you want (I'll need some help testing, at least teach me how to set up a subdomain with .htaccess in my server )

[dschwab9]

I'm making Friendly URLs and Relative URLs two separate mods now, I'll post them a bit later tonight

Awesome!  Thanks

for now, use the version of Friendly URLs that worked for you fine, just add a couple of conditions to those you wrote so that strings that have '-' or '_' are skipped too

I added  strstr($match['0'], '-') and strstr($match['0'], '_')  to my conditions of things not to be rewritten.  Is that what you wanted me to do?  That seemed to fix the previous/next buttons.

sorry for the trouble

No trouble was cause, cause I thought about the URL situation before I did it  

I'll make relative urls distiguish when the subdomains are different, so you'll be able to use that mod as well if you want

So you're saying if I visit my main Domain, the links will be relative, but if I visit one of the secondary domains, they will be absolute? Even tho both domains point to the same site?

Come to think of it, there would be an issue with subdomains too, like if I tried to use the SSI.php from my forum on my main site (which are different subdomains) - which I plan to do eventually - the home page is currently being redesigned.

(I'll need some help testing, at least teach me how to set up a subdomain with .htaccess in my server )

I'll help you to the best of my ability.

I don't think you can do a subdomain is .htaccess.  99% sure, in fact.  That would have to be setup as a virtual host in http.conf.

But, if you need a subdomain and can't do it on your server, I can give you some space on one of my boxes.

[Anguz]

Is that what you wanted me to do?

yeah, it doesn't convert that url, but it works, besides, you don't need that one to be friendly to spiders anyway

So you're saying if I visit my main Domain, the links will be relative, but if I visit one of the secondary domains, they will be absolute? Even tho both domains point to the same site?

Come to think of it, there would be an issue with subdomains too, like if I tried to use the SSI.php from my forum on my main site (which are different subdomains) - which I plan to do eventually - the home page is currently being redesigned.

the way it'll work (and should actually be working in v1.3) is that if the url is in the board's script (index.php) and is pointing to a file in the same domain as the script is, then it'll be turned relative, if not no

actually, I think it should work ok with subdomains as it is... why don't you make a copy of index.php, put the v1.3 code in it and try it really fast and tell me how it went? if it doesn't work, just put up the the original copy of index.php

if the SSI is not generated by index.php, then the urls won't be made relative, so it shouldn't be a problem

[dschwab9]

the way it'll work (and should actually be working in v1.3) is that if the url is in the board's script (index.php) and is pointing to a file in the same domain as the script is, then it'll be turned relative, if not no

Ok, I'll try that a little later tonight.  I've got a lot of people online right now, but I'll be up most of the night.

One more thing, what would it take to not make a url pasted into a message relative?  I realize that's not an operational concern, but I have a feeling it will confuse the users if the paste http://bbs.zuwharrie.com/content/board-12_action-display_threadid-1937 into a message, then when they view the post, it says just says /board-12_action-display_threadid-1937.  Or does it not work that way?

if the SSI is not generated by index.php, then the urls won't be made relative, so it shouldn't be a problem

And it's not, so scratch that thought  

[Anguz]

in v1.3, only the url that's double quoted after 'href=' or 'src=' will be made relative, not the url that's written as text, so the url in the message will be left untouched, but the actual link will be relative

look at the same message I mentioned in the other post:
http://www.laakademia.com/foros/index.php/board-17_action-display_threadid-9457_start-0#msg63823

[dschwab9]

look at the same message I mentioned in the other post:
http://www.laakademia.com/foros/index.php/board-17_action-display_threadid-9457_start-0#msg63823

Seems like when I looked at that yesterday, it showed /index.php/board-17_action-display_threadid-9457_start-0#msg63823

Did you change it?

[Anguz]

look at the same message I mentioned in the other post:
http://www.laakademia.com/foros/index.php/board-17_action-display_threadid-9457_start-0#msg63823

Seems like when I looked at that yesterday, it showed /index.php/board-17_action-display_threadid-9457_start-0#msg63823

Did you change it?

yes

I think you're looking at your cache, refresh it

I'll have to search a bit to make sure you don't look at a cached page if it has been modfied...

[dschwab9]

look at the same message I mentioned in the other post:
http://www.laakademia.com/foros/index.php/board-17_action-display_threadid-9457_start-0#msg63823

Seems like when I looked at that yesterday, it showed /index.php/board-17_action-display_threadid-9457_start-0#msg63823

Did you change it?

yes

I think you're looking at your cache, refresh it

I'll have to search a bit to make sure you don't look at a cached page if it has been modfied...

It shows the full URL today, but yesterday it just showed the relative URL, that's what I was wondering about.

Isn't there a nocache tag in all the pages?  They should never be cached, should they?

I've just got to ask, what is Alejandro and who is that guy at the top of the page?  

[Anguz]

ah ok, then it wasn't a cache problem, it's because I changed it today

Alejandro is my step-son's name (the one in the pic) and that bbs was part of his personal page before I moved it to it's own domain, but I haven't changed the template yet

[dschwab9]

I just tried 1.3, and my Stylesheet wouldn't load.  I've moved the css stuff to a separate file, which is linked like this in template.php

Code Select Expand

<link rel=stylesheet type="text/css" href="http://bbs.zuwharrie.com/bbs.css">

I tried it with:

Code Select Expand

<link rel=stylesheet type="text/css" href="bbs.css">
and

Code Select Expand

<link rel=stylesheet type="text/css" href="../bbs.css">

And neither one worked?

Seems that maybe it's rewriting the stylesheet link.  Any ideas on that?

[Anguz]

Seems that maybe it's rewriting the stylesheet link.  Any ideas on that?

could you view the source of the page generated and show me what the url is?

also, try "/bbs.css"

[dschwab9]

also, try "/bbs.css"

Ok, that made it load.  Does the / make is always relative to the site root?  Reason I ask is that the gallery runs in a subdirectory, so if i'm in the gallery, is it going to try to load /gallery/bbs.css, or will it go pull it from the site root?  Seemed to work for me, but the bbs.css file could have been cached.

An issue I'm having tho is with the images.  IE is trying to load them like this: http://bbs.zuwharrie.com/contentYaBBImages/off.gif for some reason.  If I view the source, the images are linked like /YaBBImages/off.gif, but they are showing up as broken, and if I right-click and view properties, it shows http://bbs.zuwharrie.com/contentYaBBImages/off.gif.

The images show fine in Netscape tho   (and if I view the image properties in netscape, it shows the correct URL)

[Anguz]

that's very odd

go back to the version you were using... it should work when I finish the new mods

it's probably because you're using that alias instead of index.php, or who knows... but I'll keep it in mind when writting the new code

thank you very much for your feedback, should be posting again tomorrow