[Tested BETA] Bookmarks 1.4.1 and 1.5.0

[Eloya]

On Opera the same...
No changes can be made.

Nico

[buster]

Nothing happens at my board with the bookmark mod. I also have the signature mod  installed the signature mod uses a few lines wich are also used by the bookmark mod. I don't think that this is the problem. I run the board on lycos but i'm sure that that is no problem. It's a cool mod so i hope that anyone can solve this.

Installed mods:

Global moderator
Signature
Topic solved
Add more smilies
Who is online
Collabse yabb

All working fine

[buster]

Well i have figured it out for my install.

In the bookmarks_dbchanges.php it doesnt add a line to the settings table in the database.

Add this line and it wil work

[Wistman]

Just wondering if anyone has got this working yet

I have it set up everything is correct as per the mod, the tables are all there, <yabb bookmarks> tag is in my template but I do not get anything on the board

[buster]

Just wondering if anyone has got this working yet

I have it set up everything is correct as per the mod, the tables are all there, <yabb bookmarks> tag is in my template but I do not get anything on the board

Just look into your {db_prefix}settings table if the bookmark is there if not add it and it will work i quess

[Wistman]

Yes it is there and set to 1

[buster]

Did you installed the db correct? Cause bookmarks_dbchanges.php creates a table called bookmarks and doesn't adds the prefix in front of it. Is the check box in modsettings checked or unchecked?? You should create showBookmarks in the settings table. I just installed it to my board with 26 other mods and it works fine.

[Wistman]

Did you installed the db correct? Cause bookmarks_dbchanges.php creates a table called bookmarks and doesn't adds the prefix in front of it. Is the check box in modsettings checked or unchecked?? You should create showBookmarks in the settings table. I just installed it to my board with 26 other mods and it works fine.

Are you saying that the script is looking for a table named bookmarks or that the script looks for a table named { $db_prefix}bookmarks whilst the bookmarks_dbchanges.php creates a table called bookmarks has created a table without the { $db_prefix}? My table includes the prefix.

Can I ask if you installed bookmarks before or after the other mods? (having recently found out that some funtions rely on counted variables)

[Ben_S]

Any chance of an update for 1.5.1

[oldiesmann]

While I see this mod as useful, I also see a downside to it. By allowing users to jump directly to their favorite topic(s), it takes the fun out of having a messageboard because they don't get the chance to "stop" at other topics along the way and add their 2 cents worth to topics they might otherwise skip

[Koth]

Ok I have installed all the files via boarmod or by hand perfectly fine.  I have checked my database and I have both a table called Prefix_bookmarks and the entry for showbookmakrs in my prefix_settings table.

The option is checked in mod settings and my profile and the tag is in my template and still nothing works.

[Nemesis]

Update for 1.5.1 Final Part 1:

Code Select Expand


<id>
Bookmarks
</id>

<version>
1.0 BETA
</version>

<mod info>
Note: This is the YaBB SE 1.5.1 Final version of this mod

This mod will create a drop-down list of "bookmarks".  You can easily add/remove/edit/reorder
these bookmarks.  You can create bookmarks to links within the forum, or to sites outside
the forum.
</mod info>

<author>
Joseph Fung
</author>

<homepage>
mailto:[email protected]
</homepage>

<Edit file>
index.php
</Edit file>

<Search for>
      'yabbinfo' => array("$sourcedir/Admin.php", 'showYaBBInfo'));
</Search for>

<Add before>
      'bookmarks' => array ("$sourcedir/Bookmarks.php", 'Bookmarks'),
</Add before>


<Edit file>
Sources\ModSettings.php
</Edit file>

<Search for>
   $localCookiesChecked = ($modSettings['localCookies'] == '1' ? ' checked="checked"' : '');

</Search for>

<Add after>
   $showBookmarksChecked = ($modSettings['showBookmarks'] == '1' ? ' checked="checked"' : '');

</Add after>

<Search for>
      'cal_AllowSpan' => 'cal_allowspan');

</Search for>

<Add after>
   $onoffArray ['showBookmarksChecked'] = 'showBookmarks';

</Add after>

<Search for>
                     </tr><tr>
                        <td class="windowbg2" bgcolor="' . $color['windowbg2'] . '" colspan="3" align="center" valign="middle">
                           <hr size="1" width="100%" class="windowbg3" /><input type="submit" value="' . $txt[10] . '" />
                        </td>
                     </tr>
</Search for>

<Add before>
                     </tr><tr>
                        <td class="windowbg2" bgcolor="' . $color['windowbg2'] . '" colspan="3"><hr size="1" width="100%" class="windowbg3" /></td>
                     </tr><tr>
                        <td class="windowbg2" bgcolor="' . $color['windowbg2'] . '"></td>
                        <td class="windowbg2" bgcolor="' . $color['windowbg2'] . '"><font size="2">' . $txt['bookmarks18'] . '</font></td>
                        <td class="windowbg2" bgcolor="' . $color['windowbg2'] . '"><input type="checkbox" name="showBookmarksChecked" value="1"' . $showBookmarksChecked . ' /></td>
</Add before>


<Edit file>
Sources\Load.php
</Edit file>

<Search for>
      $request = mysql_query("SELECT passwd, realName, emailAddress, websiteTitle, websiteUrl, signature, posts, memberGroup, ICQ, AIM, YIM, gender, personalText, avatar, dateRegistered, location, birthdate, timeFormat, timeOffset, hideEmail, ID_MEMBER, memberName, MSN, lngfile FROM {$db_prefix}members WHERE ID_MEMBER='$username' LIMIT 1;") or database_error(__FILE__, __LINE__);
</Search for>

<Replace>
      $request = mysql_query("SELECT passwd, realName, emailAddress, websiteTitle, websiteUrl, signature, posts, memberGroup, ICQ, AIM, YIM, gender, personalText, avatar, dateRegistered, location, birthdate, timeFormat, timeOffset, hideEmail, ID_MEMBER, memberName, MSN, lngfile, showBookmarks FROM {$db_prefix}members WHERE ID_MEMBER='$username' LIMIT 1;") or database_error(__FILE__, __LINE__);
</Replace>


<Edit file>
Sources\Profile.php
</Edit file>

<Search for>
   $request = mysql_query("
      SELECT passwd, realName, emailAddress, websiteTitle, websiteUrl, signature, posts, memberGroup, ICQ, AIM, YIM, gender, personalText, avatar, dateRegistered, location, birthdate, timeFormat, timeOffset, hideEmail, ID_MEMBER, usertitle, karmaBad, karmaGood, lngfile, MSN, secretQuestion, secretAnswer
      FROM {$db_prefix}members
      WHERE memberName='$user'") or database_error(__FILE__, __LINE__);
</Search for>

<Replace>
   $request = mysql_query("
      SELECT passwd, realName, emailAddress, websiteTitle, websiteUrl, signature, posts, memberGroup, ICQ, AIM, YIM, gender, personalText, avatar, dateRegistered, location, birthdate, timeFormat, timeOffset, hideEmail, ID_MEMBER, usertitle, karmaBad, karmaGood, lngfile, MSN, secretQuestion, secretAnswer, showBookmarks
      FROM {$db_prefix}members
      WHERE memberName='$user'") or database_error(__FILE__, __LINE__);
</Replace>

<Search for>
   if ($allow_hide_email)
   {
      $memsettings['hideEmail'] = ($memsettings['hideEmail'] == 1 ? ' checked' : '');
      echo '
                     <tr>
                        <td width="45%"><font size="2"><b>' . $txt[721] . '</b></font></td>
                        <td><input type="checkbox" name="hideemail"' . $memsettings['hideEmail'] . ' /></td>
                     </tr>';
   }
</Search for>

<Add after>
   if ($modSettings['showBookmarks'] == '1')
   {
      $a = ($memsettings['showBookmarks'] == '1') ? ' checked' : '';
      echo '<tr><td width="45%"><font size=2><b>'. $txt['bookmarks18'] .'</b></font></td><td><input type="hidden" name="showBookmarks" value=0><input type="checkbox" name="showBookmarks" value=1' . $a . '></td></tr>';
   }
</Add after>

<Search for>
   global $usertitle, $REMOTE_ADDR, $userpic_width, $userpic_height, $mbname;
</Search for>

<Add after>
   global $showBookmarks;
</Add after>

<Search for>
      $request = mysql_query("
         UPDATE {$db_prefix}members
         SET $queryPasswdPart $customTitlePart realName='$member[name]', emailAddress='$member[email]', websiteTitle='$member[websitetitle]', websiteUrl='$member[websiteurl]', signature='$member[signature]', posts=$member[settings6], memberGroup='$member[settings7]', ICQ='$member[icq]', MSN='$member[msn]', AIM='$member[aim]', YIM='$member[yim]', gender='$member[gender]', personalText='$member[usertext]', avatar='$member[userpic]', $member[dr]location='$member[location]', birthdate='$member[bday]', lngfile='$member[language]', " . ($username == $member['user'] ? "memberIP='$memIP', " : '') . "timeFormat='$member[usertimeformat]', timeOffset=$timeOffest, secretQuestion='$member[secretQuestion]', secretAnswer='$member[secretAnswer]', hideEmail=$hideEmail$karmaStr
         WHERE memberName='$user'") or database_error(__FILE__, __LINE__);
</Search for>

<Replace>
      $request = mysql_query("
         UPDATE {$db_prefix}members
         SET $queryPasswdPart $customTitlePart realName='$member[name]', emailAddress='$member[email]', websiteTitle='$member[websitetitle]', websiteUrl='$member[websiteurl]', signature='$member[signature]', posts=$member[settings6], memberGroup='$member[settings7]', ICQ='$member[icq]', MSN='$member[msn]', AIM='$member[aim]', YIM='$member[yim]', gender='$member[gender]', personalText='$member[usertext]', avatar='$member[userpic]', $member[dr]location='$member[location]', birthdate='$member[bday]', lngfile='$member[language]', " . ($username == $member['user'] ? "memberIP='$memIP', " : '') . "timeFormat='$member[usertimeformat]', timeOffset=$timeOffest, secretQuestion='$member[secretQuestion]', secretAnswer='$member[secretAnswer]', hideEmail=$hideEmail, showBookmarks=$showBookmarks$karmaStr
         WHERE memberName='$user'") or database_error(__FILE__, __LINE__);
</Replace>

<Edit file>
Sources\Subs.php
</Edit file>

<Search for>
function getMemberID($messageID)
{
   global $db_prefix;
   $result = mysql_query("
      SELECT IFNULL(mem.ID_MEMBER,-1) AS ID_MEMBER
      FROM {$db_prefix}messages AS m
         LEFT JOIN {$db_prefix}members AS mem ON (mem.ID_MEMBER=m.ID_MEMBER)
      WHERE m.ID_MSG=$messageID") or database_error(__FILE__, __LINE__);
   if (mysql_num_rows($result) > 0)
   {
      $row = mysql_fetch_array($result);
      return $row['ID_MEMBER'];
   }
   else
      return -1;
}
</Search for>

<Add after>

function yyBookmarks(){
   global $settings, $db_prefix, $ID_MEMBER, $username, $txt, $yytitle, $scripturl, $HTTP_SERVER_VARS, $modSettings;

   $onchange = ' onchange="window.location.href=this.options[this.selectedIndex].value;"';

   if ($username != 'Guest' && $modSettings['showBookmarks'] == '1')
   {
      $sql = "SELECT url, title FROM {$db_prefix}bookmarks WHERE ID_MEMBER = '" . $ID_MEMBER . "' ORDER BY display_order";
      $request = mysql_query ($sql);
      ?>
      <script>
      function addOption(theSel, theText, theValue)
      {
         var newOpt = new Option(theText, theValue);
         var selLength = theSel.length;
         theSel.options[selLength] = newOpt;
      }
      </script>
      <?php
      echo '<table border=0 cellspacing=0 cellpadding=0><form name="bookmarkFrm"><tbody><tr><td><b>' . $txt['bookmarks1'] . '</b> <select name="bookmarks"'.$onchange.'>';

      while ($row = mysql_fetch_assoc($request))
         echo '<option value="' . $row['url'] . '">' . $row['title'] . '</option>';      

      $addUrl = $scripturl . '?action=bookmarks;sub=add;title=' . urlencode($yytitle) . ';url=' . urlencode(urlencode($scripturl.'?'.$HTTP_SERVER_VARS['QUERY_STRING']));

      echo '</select> <input type=button value="' . $txt['bookmarks8'] . '" onclick="window.location.href=bookmarks.options[bookmarks.selectedIndex].value;"> <input type=button value="' . $txt['bookmarks2'] . '" onclick="window.location.href=\'' . $addUrl . '\';"> <input type=button value="' . $txt['bookmarks3'] . '" onclick="window.open(\'' . $scripturl . '?action=bookmarks;sub=edit\',\'bookmarks\',\'toolbar=no,location=no,status=no,menubar=no,scrollbars=no,width=500,height=220,resizable=no\');"></td></tr></tbody></form></table>';
  }
}

</Add after>


[Nemesis]

Update for 1.5.1 part2:

Code Select Expand

<Edit file>
english.lng
</Edit file>

<Search for>
if ($MenuType == 1)
{
</Search for>

<Add before>

// text entries for the bookmarks mod
$txt['bookmarks1'] = 'Bookmarks: ';
$txt['bookmarks2'] = 'Add';
$txt['bookmarks3'] = 'Edit';
$txt['bookmarks4'] = 'Edit Bookmarks';
$txt['bookmarks5'] = 'To reorder your bookmarks, select the<br />bookmark and use the up and down buttons<br />to move it thoughout the list accordingly.';
$txt['bookmarks6'] = 'Move Up';
$txt['bookmarks7'] = 'Move Down';
$txt['bookmarks8'] = 'Go';
$txt['bookmarks9'] = 'What caption do you want to use?';
$txt['bookmarks10'] = 'My Bookmark';
$txt['bookmarks11'] = 'What is the URL?';
$txt['bookmarks12'] = 'Rename';
$txt['bookmarks13'] = 'Please enter the new name';
$txt['bookmarks14'] = 'Change URL';
$txt['bookmarks15'] = 'Please enter the new URL';
$txt['bookmarks16'] = 'Save Changes';
$txt['bookmarks17'] = 'Cancel';
$txt['bookmarks18'] = 'Enable Bookmarks?';

</Add before>

// This file simply contains replacement code for languages other than english.lng
// We have German, Dutch and Spanish

<Edit file>
german.lng
</Edit file>

<Search for>
if ($MenuType == 1)
{
</Search for>

<Add before>

// text entries for the bookmarks mod
$txt['bookmarks1'] = 'Bookmarks: ';
$txt['bookmarks2'] = 'Hinzufügen';
$txt['bookmarks3'] = 'Editieren';
$txt['bookmarks4'] = 'Editiere Bookmarks';
$txt['bookmarks5'] = 'Zum Umsortieren den<br />Bookmark auswählen und die Aufwärts und Abwärts Buttons benutzen<br />.';
$txt['bookmarks6'] = 'Aufwärts';
$txt['bookmarks7'] = 'Abwärts';
$txt['bookmarks8'] = 'Gehe zu';
$txt['bookmarks9'] = 'Bezeichnung?';
$txt['bookmarks10'] = 'Meine Bookmarks';
$txt['bookmarks11'] = 'URL?';
$txt['bookmarks12'] = 'Umbenennen';
$txt['bookmarks13'] = 'Bitte geben Sie den neuen Namen ein';
$txt['bookmarks14'] = 'URL ändern';
$txt['bookmarks15'] = 'Bitte neue URL eingeben';
$txt['bookmarks16'] = 'Änderungen speichern';
$txt['bookmarks17'] = 'Abbrechen';
$txt['bookmarks18'] = 'Bookmarks aktivieren?';

</Add before>

<Edit file>
dutch.lng
</Edit file>

<Search for>
if ($MenuType == 1)
{
</Search for>

<Add before>

// dutch text entries for the bookmarks mod
$txt['bookmarks1'] = 'Snelkoppelingen: ';
$txt['bookmarks2'] = 'Voeg toe';
$txt['bookmarks3'] = 'Bewerk';
$txt['bookmarks4'] = 'Bewerk snelkoppelingen';
$txt['bookmarks5'] = 'Om je snelkoppelingen te rangschikken, selecteer de<br />snelkoppeling en gebruik de omhoog en omlaag knoppen<br />om deze te verschuiven';
$txt['bookmarks6'] = 'Omhoog';
$txt['bookmarks7'] = 'Omlaag';
$txt['bookmarks8'] = 'Ga';
$txt['bookmarks9'] = 'Welke omschrijving wil je gebruiken?';
$txt['bookmarks10'] = 'Mijn snelkoppeling';
$txt['bookmarks11'] = 'Wat is de URL?';
$txt['bookmarks12'] = 'Hernoem';
$txt['bookmarks13'] = 'Voer de nieuwe naam in';
$txt['bookmarks14'] = 'Verander de URL';
$txt['bookmarks15'] = 'Voer de nieuwe URL in';
$txt['bookmarks16'] = 'Sla de veranderingen op';
$txt['bookmarks17'] = 'Annuleren';
$txt['bookmarks18'] = 'Activeren snelkoppelingen?';

</Add before>

<Edit file>
spanish.lng
</Edit file>

<Search for>
if ($MenuType == 1)
{
</Search for>

<Add before>

// text entries for the bookmarks mod
$txt['bookmarks1'] = 'Bookmarks: ';
$txt['bookmarks2'] = 'Agregar';
$txt['bookmarks3'] = 'Editar';
$txt['bookmarks4'] = 'Editar Bookmarks';
$txt['bookmarks5'] = 'Para reordenar los bookmarks, selecciona el<br />bookmark y usa los botones de arriba y abajo<br />para moverlos a través de la lista.';
$txt['bookmarks6'] = 'Mover Arriba';
$txt['bookmarks7'] = 'Mover Abajo';
$txt['bookmarks8'] = 'Ir';
$txt['bookmarks9'] = '¿Qué mensaje deseas usar?';
$txt['bookmarks10'] = 'Mi Bookmark';
$txt['bookmarks11'] = '¿Cuál es el URL?';
$txt['bookmarks12'] = 'Renombrar';
$txt['bookmarks13'] = 'Por favor introduce el nuevo nombre';
$txt['bookmarks14'] = 'CambiarURL';
$txt['bookmarks15'] = 'Por favor introduce el nuevo URL';
$txt['bookmarks16'] = 'Guardar Cambios';
$txt['bookmarks17'] = 'Cancelar';
$txt['bookmarks18'] = '¿Activar Bookmarks?';

</Add before>


[Nemesis]

First post Jospeh made now contains an updated mod file, you can simple download and install via boardmod proggy or manually.

Nemey

[Wiziwig]

Still dont seem to be working right. Db sees the settings, modsettings see the settings, the <tagname> is in template. But, in the index, none of the bookmarks show. When I click on edit, and in the editor select a bookmark from the list, select save, the bookmark appears in the index display. I click on the go button and it takes me to the bookmark, but the bookmark list in the index display disappears again.

Here's the screenshots:

1. Nothing in the index view
http://www.clubmasa.com/debug/bookmark1.jpg

2. Bookmark editor says yes, there is something here.  So lets go and check that and select save
http://www.clubmasa.com/debug/bookmark2.jpg

3. Oh great, good news! now something shows in the index view
http://www.clubmasa.com/debug/bookmark3.jpg

4. No wait, I click on go and the list is gone again!
http://www.clubmasa.com/debug/bookmark4.jpg

Maybe the culprit is in function yyBookmarks(){ of subs.php ??