[beta 1.5.4] Smart URLs v2.1

[Anguz]

that's odd... did you apply the change I told you for that? in subs.php, you should have this

Code Select Expand

         if($modSettings['smartUrl'] == 1 && ($modSettings['sUrl_counter'] == 1 || $settings[7] == 'Administrator')){
            global $urlCount, $sUrl_time;
            $sUrl_time = round($sUrl_time, 3);
            $sUrl_counter = '<br />Smart URLs: +'.$sUrl_time.'s smart_url('.$urlCount.')';
         }else
            $sUrl_counter = '';


that means that if Smart URLs is on and you're either the admin or the counter is on, then it'll show it

[dschwab9]

how stupid... I forget to make that var global too

find this line in display.php

Code Select Expand

      global $kwYabbse, $kwCateg, $boardCat, $kwTitleSep, $currentboard;
and change it to

Code Select Expand

      global $kwYabbse, $kwCateg, $boardCat, $kwBoard, $kwTitleSep, $currentboard;

sorry  

I'll fix the mod file right now... done

did the separator work well? did the keywords with dashes between them, show without them in the title? I'm guessing you're not using a kw for the whole community, so it won't show

Ok, that fixed it.  Only thing is the keywords I'm using in the URL's don't really make sense in the Title, so I turned it off, but it does work.

[dschwab9]

that's odd... did you apply the change I told you for that? in subs.php, you should have this

Code Select Expand

         if($modSettings['smartUrl'] == 1 && ($modSettings['sUrl_counter'] == 1 || $settings[7] == 'Administrator')){
            global $urlCount, $sUrl_time;
            $sUrl_time = round($sUrl_time, 3);
            $sUrl_counter = '<br />Smart URLs: +'.$sUrl_time.'s smart_url('.$urlCount.')';
         }else
            $sUrl_counter = '';


that means that if Smart URLs is on and you're either the admin or the counter is on, then it'll show it

This is what you told me to do:

Code Select Expand

<search for>
         if($modSettings['smartUrl'] == 1 && $modSettings['sUrl_counter'] == 1){
</search for>

<replace>
         if($modSettings['smartUrl'] == 1 && ($modSettings['sUrl_counter'] == 1 || $settings[7] == 'Administrator')){

I just varified that it is, in fact, there, but it doesn't work.  That section of my subs.php looks like:

Code Select Expand


      $curline = $yytemplate[$i];
      if (!$yycopyin && strstr($curline,'<yabb copyright>'))
         $yycopyin = 1;
      $tags = array();
      while (preg_match("/<yabb\s+(\w+)>/", $curline, $tags))
      {
         $temp = "yy$tags[1]";
         if (function_exists($temp))
         {
            ob_start();
            $temp();
            $str = ob_get_contents();
            $curline = preg_replace("/<yabb\s+$tags[1]>/", $str, $curline);
            ob_end_clean();
         }
         else
            $curline = preg_replace("/<yabb\s+$tags[1]>/",$$temp,$curline);
      }
      if ($modSettings['timeLoadPageEnable'] == 1 && stristr($curline, '</body>'))
      {
         $time_end = getmicrotime();
         $time = round($time_end - $time_start, 3);
                  if($modSettings['smartUrl'] == 1 && ($modSettings['sUrl_counter'] == 1 || $settings[7] == 'Administrator')){
            global $urlCount, $sUrl_time;
            $sUrl_time = round($sUrl_time, 3);
            $sUrl_counter = '<br />Smart URLs: '.$sUrl_time.'s smart_url('.$urlCount.')';
         }else
            $sUrl_counter = '';
         $curline = preg_replace('/<\/body>/i', '<div align="center"><font size="1">' . $txt['yse301'] . $time . $txt['yse302'] . $sUrl_counter . '</font></div></body>', $curline);
      }

      echo "$curline\n";
   }


[dschwab9]

Scratch all that stuff about the counter.

* dschwab9 did a typo in subs.php  

[Anguz]

the code looks alright... and if it's working like that, then I should be able to see the counter, but it's not there

[Anguz]

Scratch all that stuff about the counter.

* dschwab9 did a typo in subs.php  

lol I was really scratching my head  

[pege]

man....googlebot and a few other engines hit my site over the last couple days.  the most links they spidered was 13 out of 390 posts.  any tips?

moved the page to

www.pege.net

[Cerberus]

After reading the last posts I've decided that I'll wait a bit to see a "working" version

[Anguz]

I thought it was working fine already... what's wrong that wasn't fixed? maybe I missed it

[Cerberus]

I don't know, but I'd like to install a version which has been completely tested to prevent possible problems on my website.

PS: the version 1 is great too (truly).

[dschwab9]

I don't know, but I'd like to install a version which has been completely tested to prevent possible problems on my website.

PS: the version 1 is great too (truly).

I'm running 2.1, and it works fine - http://bbs.zuwharrie.com/

[dschwab9]

man....googlebot and a few other engines hit my site over the last couple days.  the most links they spidered was 13 out of 390 posts.  any tips?

moved the page to

www.pege.net

Google is not spidering right now - they are updating their cached version of existing pages.  I'm seeing the same thing on all of my sites.  They are only visiting pages that are already in the index it appears.  I would expect another deep crawl in a week or too based on the schedule I've been seeing.

[pege]

I thought it was working fine already... what's wrong that wasn't fixed? maybe I missed it

You did a good job Anguz.  It was just my ignorance about how Google is crawling the pages right now.  This program does just what it says, and it runs stable.  Thanks!

[Anguz]

I'm glad to hear that guys... let me know as soon as a bug crawls out, if there's any left that is

also, I want to mention an advantage I just noticed, well, I thought of it originally, but had forgotten it since and now i remembered  

when I start typing my community's url, I get a list of the urls I've visited that start the same, so I can choose to jump to the one i'm looking for much faster

this is not new, but what's new, is that now I can tell what thread it is, or at least the board, from the keywords in the url... where before I had to go to the index to find my way

I don't know if that made sense, I probably didn't say it right  

for this purpose, I had thought of including the title in the url as a directory too, but then discarded it cause it'd make the url too long lol

[Cerberus]

I've installed by hand the v2.1 and I have a problem. When I click on a board link I'm being redirected to the main page . Could this be a pfabb-related issue .