Need your opinion (changing smiley)

[Jeff Lewis]

We are having problems with this little fella  :-\ and I am debating changing it to :-S in order to get around the problem.

[Vin99NL BOFH]

What a splendid idea

[andrea]

I have some questions referring to that:

[*]what problem do you have with the :-\ ? In my board I do not experience any problems with the "undecided" smiley (did not install any mods, is the problem with some mods?).
[*]In my smiley book the "undecided" smiley is coded like this:  :-/
So an alternative could be that you replace by :/
Would this cause problems, too?
[*]What are the consequences for posts containing the old smiley code?
[*]What about the "embarassed" smiley:  :-[
This one is causing problems when used with the quote tag (suppose that the same with the code tag), see this and this posts. But this  :-[  smiley code is maybe a more classical one and cannot be replace therefore.
[/list]

[Jeff Lewis]

Yes I have to revisit it I do believe...I have been out of it all day (day off so I am relaxing) but tomorrow will look in depth.

[andrea]

So enjoy your free day.  :)  Added one more question to my previous post.

Here an idea, referring to the "embarassed" smiley  :-[ problem: the problem is only when right after the smiley there is a [/quote without a space between the smiley and the tag, for example:
 :-[ [/quote
(take the blank between the two "[" characters out)

Maybe this problem can be fixed without changing the smiley symbol, by just interpretating first the [/quote tag and afterwards the smiley code (just changing the priority when interpreting the line input).

Edit: just seen that YaBB SE changes the string :-[ [/quote to :-[/quote if the two "[" characters are in sequence, without a space in between. Maybe the solution is just to take this out?

"[["  (<- you see one bracket "[" but I entered 2 of them! - you can see it if you edit my post)

[Peter Crouch]

I think the "huh" smilie should not be "", it totally ruins the effect when asking a dramatic question. Maybey something along the lines of ":-?"

And what problems is "" causing?

[andrea]

I think the "huh" smilie should not be "", it totally ruins the effect when asking a dramatic question. Maybey something along the lines of ":-?"

And what problems is "" causing?

Don't agree here. I like the effect of turning 3 "?" into a smiley. It's no damage if posts that are excessively using punctuation marks are converted a little.  

Furthermore, the smiley codes should not be changed if not absolutely necessary. It would mess the board data and needs a "restructure" of the board data when applying the new source release.

[Jeff Lewis]

There are a couple of smilies causing problems.  Both are related to not having space after them - sort of.

One smiley causes a parse error (in the bug tracker and mentined on here).  The other in the smiley error where it messes up a quote and then the format of a board...

[andrea]

There are a couple of smilies causing problems.  Both are related to not having space after them - sort of.

One smiley causes a parse error (in the bug tracker and mentined on here).  The other in the smiley error where it messes up a quote and then the format of a board...

I looked into the bug tracker, its no. 000068
I think the two smiley problems are equal, and am quite sure you can solve them without changing the smiley codes.

I did not look into the YaBB SE source code, but I'm supposing you do the following:
A smiley string such as  :-[ is replaced by an IMG tag, a YABBC "quote" or "code" tag is replaced by a 1x1 html table. The problem arises when there is no space between the smiley code and the "end of quote" (or code) tag. My impression is that the smiley is first parsed, and after this the quote or code tag is parsed.
Idea: If the parsing order would be reversed, that means: first process the quote and code tags, and afterwards process the smiley codes, the board would not be messed up. Right?

[Jeff Lewis]

You may be right but Zef would have to take a look at it, he wrote the routine and I am unfamiliar with it...

[Zef Hemel]

I have no idea why :-\ causes problems, but in some way it does. :-[ (with double [) can be explained though, it's not a bug it's a feature. It allows you to write down UBBC tags without having them parsed [[[]]] for example would not be parsed but translated into []

[andrea]

:-[ (with double [) can be explained though, it's not a bug it's a feature. It allows you to write down UBBC tags without having them parsed [[[]]] for example would not be parsed but translated into []

but a
:-[ [ /quote ]
is not a
[ [ b ] ]
I suppose refining the if's could solve this problem.

[Zef Hemel]

Yeah, well it's not that simple but I'll try make up a simple fix for it, give me a minute

[Zef Hemel]

test

Well that seemed to fix the problem (not the one though)

[andrea]

Yeah, well it's not that simple but I'll try make up a simple fix for it, give me a minute

Never pretended that this is simple.    And its very ok if you need more than a minute.