Quote borders

[Taildragger]

Since I upgraded to 1.5.1 the borders on my quote boxes are very thick even though my template still says "1px".  What might be causing this?

Thanks.

[Spaceman-Spiff]

can u copy and paste the whole .quote style

[Taildragger]

can u copy and paste the whole .quote style

Well, here is what I have now:

Code Select Expand

.quote       {FONT-SIZE: xx-small; COLOR: #000000; FONT-FAMILY: Verdana, arial, helvetica, serif;
      BACKGROUND-COLOR: #eeeeee; BORDER: 0px solid #cccccc}

But this still results in a black border.  It looks like, for some reason, I'm getting two borders on my quotes.  One is an outside black border that I can't get rid of, and then I get another one inside that that goes along with my .quote style.

Maybe I messed up something else in the CSS to make it do this?  It didn't do it before I upgraded to 1.5.1 though.

Here's a link to the site and a page with some quotes in it:

http://www.libertarianunderground.com/Forum/index.php?board=2;action=display;threadid=447;start=40

Thanks.

PS: I'm seeing double thick quote borders here as well, even though if I view the yabbse.css it says "1px".  

[andrea]

Here's a link to the site and a page with some quotes in it:

http://www.libertarianunderground.com/Forum/index.php?board=2;action=display;threadid=447;start=40
ugh if I view the yabbse.css it says "1px".  

The border around the quotes in this link looks fine to me, not thicker than 1px. I was using MSIE 6.0. Which browser are you using? Maybe it is a browser issue?

[A.M.A.]

Here's a link to the site and a page with some quotes in it:

http://www.libertarianunderground.com/Forum/index.php?board=2;action=display;threadid=447;start=40

Thanks.

strange   it looks fine 4 me tho.. no thick borders!

PS: I'm seeing double thick quote borders here as well, even though if I view the yabbse.css it says "1px".  

Yup.. I thought they did this Intentionally.. or it is just IE6!

[Taildragger]

I'm sorry, I must not have been clear.  My .quote is now set up for a 0px border, and the color is not black.  Yet somehow it comes out 1px thick anyway.  If I put 1px in my .quote in the CSS, then it comes out 2 pixels wide, with an inner border of the color specified and the outer border black.

In other words, it's like there's always a 1px black border and all the .quote is doing is adding an additional border inside this.

I'd like to have a 1px border, but I don't want it to be black.

Thanks again.

[Spaceman-Spiff]

the HTML code in your forum:

Code Select Expand

<table width="100%" border="0" cellspacing="0" cellpadding="0" bgcolor="#000000"><tr><td><table border="0" cellspacing="1" cellpadding="2" width="100%"><tr><td class="quote">I'm not sure of the point you are making here.</td></tr></table></td></tr></table>

it's using nested tables, so it's using the bgcolor of the parent table for the border
is this by default in 1.5.1?
i gotta take a look at the codes...

[Spaceman-Spiff]

shows in this forum too

Code Select Expand

<table width="100%" border="0" cellspacing="0" cellpadding="0" bgcolor="#000000"><tr><td><table border="0" cellspacing="1" cellpadding="2" width="100%"><tr><td class="quote">can u copy and paste the whole .quote style <br /></td></tr></table></td></tr></table><br />
this is because of the hardcoded bgcolor in Subs.php
it should be removed, IMO
the line in Subs.php:

Code Select Expand

        "'<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\"><tr><td><font size=\"1\"><b><a href=\"$scripturl?action=display;\\2\">$txt[yse239]: \\1 $txt[176] '.timeformat('\\3').'</a></b></font></td></tr></table><table width=\"100%\" border=\"0\" cellspacing=\"0\" cellpadding=\"0\" bgcolor=\"#000000\"><tr><td><table border=\"0\" cellspacing=\"1\" cellpadding=\"2\" width=\"100%\"><tr><td class=\"quote\">'",
and i think a <div> tag will be better than table

EDIT: added to bugtracker: http://sourceforge.net/tracker/index.php?func=detail&aid=700111&group_id=57105&atid=482971

[Taildragger]

SS,

Wouldn't removing the cellspacing=1 solve this problem?  That would probably taking the automatic bordering away and allow the .quote CSS setting to do its thing.

[Spaceman-Spiff]

yes it will, removing the bgcolor will too i think...
or removing the parent table

[Taildragger]

yes it will, removing the bgcolor will too i think...
or removing the parent table

There are about 4 places in Subs.php where it says class=".quote".  Should I change them all?

Why the heck does YaBB have so many nested tables?  I modified my template so it only has one table and I can't see any difference.  Maybe it makes a difference for old Netscape users or something?  New IE seems to have no problem making a 1px border without nesting 3 tables deep for everything.

[Spaceman-Spiff]

it was done so the layout will still look good on non-CSS-compatible browsers (old browsers)

i think there are around 3 lines that u need to change
2 for quote and 1 for code
see the link to the bugtracker above, i posted the line numbers
u can just open Subs.php and search for '#000000'

[Taildragger]

Well, I changed every spot where I saw class=.quote so that cellspacing="0".  This seemed to fix it up, but I'm not sure what they were all for.  Some of them were PHP with /'s before the quotes and some were straight HTML.  I haven't messed with the .code yet.

The good thing about doing it this way is that the CSS can be used to change the color.

Re: nested tables, I guess it just won't look as good to people with an ancient browser.  

[Taildragger]

Another bug report I think:

I noticed that my Subs.php has no class="code" in it anywhere.  Sure enough, if I use code or quote in my forum, it does exactly the same thing.  If I view the source of a page with a code box, it is using class="quote".

Weird.

[Spaceman-Spiff]

you're right it was using class="code" in the older version (maybe 1.0?), seems like its been like that since v1.3
added to the bugtracker