preg_match trouble

[Armadillo]

I recently upgraded to 1.5.1 from 1.4.1. All files are uploaded and the board works fine.
Except, it still has a bug that caused me trouble in 1.4.1 (after PHP was upgraded to 4.3.0).
Some users (and me in tests) get an invalid character in username error when they log in. There are no illegal characters in the usernames.

I have found two things that I suspect.
Here is the code from Register.php....

Code Select Expand


if (!preg_match("/^[\s0-9A-Za-z#,-\.:=?@^_äöéèöüçåãâáàßêìíîïðñòóôõøùúûýÿ]+$/",$user))
fatal_error($txt[240]);

Here is the code from LogInOut.php....

Code Select Expand


if (!preg_match("/^[\s0-9A-Za-z#%+,-\.:=?@^_äöéèöüçåãâáàßêìíîïðñòóôõøùúûýÿ]+$/", $user))
fatal_error($txt[240]);

They both check the username for invalid characters, but they are not the same!
The code from LogInOut.php contains "%+" while the code from Register.php does not.
I suspect the code in LogInOut.php is causing the trouble. I dont know much about PHP, so I may be wrong.

Also, the pattern is in double quotes. Shouldn't it be in single quotes?

My question is, can I replace the code in LogInOut?
Or can I eliminate this code altogether?
Is it really necessary to check for all of those characters?

[[Unknown]]

Having these characters in usernames can cause problems.

You should probably be able to replace them both with:

if (!preg_match('/^[\s0-9A-Za-z#,\-\.:=?@^_äöéèöüçåãâáàßêìíîïðñòóôõøùúûýÿ]+$/',$user))
  fatal_error($txt[240]);

-[Unknown]

[Armadillo]

Thanks. I'll give it a try.

The member names in question did not have any illegal charactors. Example- Major Glare

That name (and a few others) will be accepted by Register.php but not by LogInOut.php. Limiting the size of the username seems to help.

I suspect PHP 4.3.0 may be misinterpreting the code in LogInOut.php.

[Armadillo]

Well, that wasn't it.
Both PHP scripts use the same preg_match code now (the one from [Unknown]) and it still does it.

The user names are all alpha characters and spaces. They are allowed to register, but when they log in they get the error message.
This seems to mainly effect some long names, so I have limited the length to 10 characters. I did the same thing with 1.4.1.

Anyone have any other ideas?